Skip to content

Fix valgrind defects from cellular #9457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 31, 2019
Merged

Fix valgrind defects from cellular #9457

merged 4 commits into from
Jan 31, 2019

Conversation

blind-owl
Copy link
Contributor

Description

Fixed cellular unit tests regarding valgrind reported memory leaks.

Test coverage includes unit tests on CI and on-target cellular tests on MTB_MTS_DRAGONFLY target 
 with GCC_ARM. No new failures (the existing one still fails in master)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x ] Test update
[ ] Breaking change

Reviewers

@cmonr cmonr requested a review from a team January 22, 2019 17:28
@blind-owl blind-owl changed the base branch from master to feature-cellular-refactor January 23, 2019 07:28
@blind-owl blind-owl force-pushed the fix_valgrind_defects_from_cellular branch from e5937ba to 626935f Compare January 23, 2019 07:46
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

Can you review doxy job failure ? The word seems to be valid, in that case should be added.

@0xc0170 0xc0170 requested a review from AnotherButler January 23, 2019 10:34
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

@AnotherButler can you check this addition; 9f9fce4

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 25, 2019

Test run: FAILED

Summary: 6 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 25, 2019

There are build failures, possibly bad rebase for the feature branch?

@AriParkkila
Copy link

@0xc0170 please merge first #9472

@cmonr cmonr removed the needs: CI label Jan 28, 2019
@AriParkkila
Copy link

@0xc0170 please restart build

@cmonr
Copy link
Contributor

cmonr commented Jan 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 31, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@AriParkkila AriParkkila mentioned this pull request Jan 31, 2019
Closed
@0xc0170 0xc0170 merged commit 50b5f57 into ARMmbed:feature-cellular-refactor Jan 31, 2019
@blind-owl blind-owl deleted the fix_valgrind_defects_from_cellular branch February 1, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AnotherButler AnotherButler AnotherButler approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@blind-owl @0xc0170 @mbed-ci @AriParkkila @cmonr @AnttiKauppila @AnotherButler @NirSonnenschein