Skip to content

Add STM32F415xG target support. #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add STM32F415xG target support. #13417

wants to merge 3 commits into from

Conversation

jimsynz
Copy link

@jimsynz jimsynz commented Aug 11, 2020

Summary of changes

Adds support for the STM32F415xG family of microprocessors.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jimsynz
Copy link
Author

jimsynz commented Aug 11, 2020

Hi folks. This is my first PR to mbed-os, so I'm not exactly sure what I'm supposed to do about running mbed test AFAICT I can't run them because I haven't actually added a board - is that correct?

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 11, 2020
@ciarmcom
Copy link
Member

@jimsynz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 11, 2020 23:00
@jeromecoutant
Copy link
Collaborator

I'm not exactly sure what I'm supposed to do about running mbed test AFAICT I can't run them because I haven't actually added a board - is that correct?

Yes, you need a target to execute tests.

@jeromecoutant
Copy link
Collaborator

For information, I understood that this request goal would to support
https://1bitsy.org/
in custom targets

Thx @jimsynz

jeromecoutant
jeromecoutant reviewed Aug 12, 2020
View reviewed changes
jeromecoutant
jeromecoutant suggested changes Aug 12, 2020
View reviewed changes
@jimsynz
Copy link
Author

jimsynz commented Aug 12, 2020

Thanks for the review @jeromecoutant. Changes made.

@jimsynz jimsynz requested review from jeromecoutant and removed request for a team August 12, 2020 22:53
jeromecoutant
jeromecoutant suggested changes Aug 13, 2020
View reviewed changes
0xc0170
0xc0170 previously requested changes Aug 14, 2020
View reviewed changes
@mergify mergify bot dismissed 0xc0170’s stale review August 17, 2020 22:17

Pull request has been modified.

@jimsynz
Copy link
Author

jimsynz commented Aug 24, 2020 •
edited
Loading

@0xc0170 is there anything more needed for this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 24, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_wisun-mesh-test ✔️

@jeromecoutant
Copy link
Collaborator

Let's merge ?

@jimsynz
Copy link
Author

jimsynz commented Sep 9, 2020

@jeromecoutant do you want me to rebase first?

0xc0170
0xc0170 previously requested changes Sep 10, 2020
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F415xG/TOOLCHAIN_ARM/stm32f415xx.sct
#define MBED_APP_SIZE MBED_ROM_SIZE
#endif

#if !defined(MBED_BOOT_STACK_SIZE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change landed on master recently, t hat is fixing this MBED_BOOT_STACK_SIZE. see #13452 for details. Can you update?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2020

Once it is updated, we will start CI and this shall go in. Sorry for the delay.

@mergify mergify bot dismissed 0xc0170’s stale review September 14, 2020 04:00

Pull request has been modified.

@mergify
Copy link

mergify bot commented Sep 14, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

CI restarted

@mergify mergify bot added needs: work and removed needs: CI labels Sep 15, 2020
@mbed-ci
Copy link

mbed-ci commented Sep 15, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ❌
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_wisun-mesh-test ✔️

@jimsynz jimsynz marked this pull request as draft September 27, 2020 19:58
@jimsynz
Copy link
Author

jimsynz commented Sep 27, 2020

Sorry for the delay. I started a new job a few weeks ago and have been pretty slammed. I will come back to this, I promise.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

@jimsynz that is OK, please reopen once it is updated. I'll close this meanwhile.

@0xc0170 0xc0170 closed this Oct 19, 2020
@mergify mergify bot removed needs: work release-type: patch Indentifies a PR as containing just a patch labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimsynz @ciarmcom @jeromecoutant @0xc0170 @mbed-ci