Introduce performance regression CI check #2294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using [Gimbal](https://github.com/ModusCreateOrg/gimbal) and GitHub Actions to ensure Performance Budgeting on VueJS.org homepage. This CI action will * [x] ensure lighthouse tests don’t fall below thresholds * [x] ensure a11y rules are observed * [x] ensure heap memory doesn’t go over the threshold * [x] automatically create a PR comment with items that are failing The thresholds are loose to reflect the current state of the built site. Some of the tests are skipped as they are taken care of on the server side post-deployment.
|
@bencodezen since you are leading the charge for vuepresss migration, I think your input on this is important |
|
@sdras Thanks for pinging me. Sorry for missing the notification on this one and not seeing it till now. I'll definitely need to play around with Gimbal to see how it interacts with VuePress. Will keep you posted. 👍 |
|
Thanks @bencodezen and @sdras. Please let me know if I can help with anything there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Gimbal and GitHub Actions to ensure Performance Budgeting on the VueJS.org homepage.
This CI action will
The thresholds are loose to reflect the current state of the built site. Some of the tests are skipped as they are taken care of on the server side post-deployment.
Gimbal is not made a dependency to keep the dependency tree light (apart from the light axe plugin). However, it can be executed locally via a CLI command as such: