Skip to content

cleanup: update workflows, bump snap version #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This workflow will upload a Python Package using Trusted Publishers automatically when a release is created
# This workflow will upload a Python Package using Trusted Publishers automatically when a release is created and the deployment is approved by an admin
# For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries
# and https://docs.pypi.org/trusted-publishers/using-a-publisher/.

Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ jobs:
run: |
python3 -m pip install .
tldr --version
tldr tldr --markdown

build-macos:
runs-on: macos-latest
needs: ['build-linux']

permissions:
contents: read
Expand Down Expand Up @@ -97,10 +97,10 @@ jobs:
run: |
python3 -m pip install .
tldr --version
tldr tldr --markdown

build-windows:
runs-on: windows-latest
needs: ['build-macos']

permissions:
contents: read
Expand Down Expand Up @@ -144,10 +144,10 @@ jobs:
run: |
python3 -m pip install .
tldr --version
tldr tldr --markdown

build-windows-arm:
runs-on: windows-11-arm
needs: ['build-windows']

permissions:
contents: read
Expand Down Expand Up @@ -183,11 +183,10 @@ jobs:
run: |
python3 -m pip install .
tldr --version
tldr tldr --markdown

build-snap:
runs-on: ${{ matrix.os }}
if: github.repository == 'tldr-pages/tldr-python-client' && github.ref == 'refs/heads/main'
if: github.repository == 'tldr-pages/tldr-python-client' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/'))
needs: ['build-linux']

permissions:
Expand Down
2 changes: 1 addition & 1 deletion snap/snapcraft.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: tldr
base: core24
version: '3.4.0'
version: '3.4.1'
summary: tldr python client
description: Official Python command-line client for tldr pages.

Expand Down
Loading