[Translation] Clarifying LocaleSwitcher's behavior #20981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
suggested changes
May 20, 2025
Comment on lines
+1109
to
+1118
| The LocaleSwitcher will apply the locale at a request level | ||
| this means that it will be available only for that request. A | ||
| redirect, for example, will cancel the LocaleSwitcher's effect. | ||
| For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session. |
There was a problem hiding this comment.
Suggested change
| The LocaleSwitcher will apply the locale at a request level | |
| this means that it will be available only for that request. A | |
| redirect, for example, will cancel the LocaleSwitcher's effect. | |
| For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session. | |
| The LocaleSwitcher will apply the locale at a request level. | |
| This means that it will be available only for that request. | |
| A redirect, for example, will cancel the LocaleSwitcher's effect. | |
| For a permanent locale switch between requests see https://symfony.com/doc/current/session.html#making-the-locale-sticky-during-a-user-s-session. |
About the URL, can you follow the RST format for links please? (see https://github.com/symfony/symfony-docs/pull/20981/files#diff-9ee808b36fb9f3ce98827e47f96d7bf1d53c039fed97fb8364087cd629be779cR1095)
carsonbot
changed the title
|
Thanks Kévin! We merged this in 6.4 and did the changes proposed by Mathieu (and some other rewords) while merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.