minor #19722 [VarExporter] Remove "lazyObjectId" from LazyGhostTrait because it doesn't seem to do anything (mickaelblondeau)

javiereguiluz · javiereguiluz · commit 4e0fbbdd07f7 · 2024-04-02T08:22:14.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [VarExporter] Remove "lazyObjectId" from LazyGhostTrait because it doesn't seem to do anything Hello, If I didn't miss any hidden dynamic resolving black magic, the variable "lazyObjectId" doesn't seem to have any uses for LazyGhost to work, if that's the case, I made the modification to remove this potentially missleading part of the documentation Commits ------- d073142 Update var_exporter.rst
diff --git a/components/var_exporter.rst b/components/var_exporter.rst
@@ -210,9 +210,6 @@ initialized::
     class HashProcessor
     {
         use LazyGhostTrait;
-        // Because of how the LazyGhostTrait trait works internally, you
-        // must add this private property in your class
-        private int $lazyObjectId;
 
         // This property may require a heavy computation to have its value
         public readonly string $hash;

Original file line number	Diff line number	Diff line change
`@@ -210,9 +210,6 @@ initialized::`
`210`	`210`	`class HashProcessor`
`211`	`211`	`{`
`212`	`212`	`use LazyGhostTrait;`
`213`		`- // Because of how the LazyGhostTrait trait works internally, you`
`214`		`- // must add this private property in your class`
`215`		`- private int $lazyObjectId;`
`216`	`213`
`217`	`214`	`// This property may require a heavy computation to have its value`
`218`	`215`	`public readonly string $hash;`