Skip to content

Add a dedicated file deletion for unconfigure recipes #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

maxhelias
Copy link
Contributor

Re-open #667

In this way, we correct the deletion of the same file imported by 2 recipes.
Factoring in this way would allow us to remove the $lock parameter passing in the unconfigure method and with a little more work in the configure.

WDYT about this way ? Can I continue in this direction?

tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
@nicolas-grekas nicolas-grekas changed the base branch from main to 1.x November 22, 2021 18:19
@maxhelias
Copy link
Contributor Author

Outdated and should be resolve in #845

@maxhelias maxhelias closed this Dec 17, 2021
@nicolas-grekas
Copy link
Member

@maxhelias up to rebase this for 2.x?
It looks like we might need this: removing phpunit-bridge currently removes files that should be kept for phpunit when it remains and you had the answer apparently.

@nicolas-grekas nicolas-grekas changed the base branch from 1.x to 2.x May 20, 2025 15:11
@maxhelias
Copy link
Contributor Author

@nicolas-grekas Yes, of course, I think I'll have to work on it again after all this time 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants