-
Notifications
You must be signed in to change notification settings - Fork 102
feat(completions): autocomplete for function types #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
psteinroe
merged 16 commits into
supabase-community:main
from
juleswritescode:feat/completions-fn
Dec 16, 2024
Merged
feat(completions): autocomplete for function types #155
psteinroe
merged 16 commits into
supabase-community:main
from
juleswritescode:feat/completions-fn
Dec 16, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Two nits, but we can merge 🙏🏼
@juleswritescode, sorry, can you fix the conflict again? Should have merge the other pr after this one |
Check!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocompletions for functions! Some rules that are applied:
select
clause, we'll prefer function items over table itemsfrom
clause, we'll slightly prefer table itemsI refactored the
CompletionRelevance
again; now we can update the score based on the completion item score.I also added docs to the SchemaCache's
Function
and changed the query. Some properties wereOption
s, even though they should always be present:id
,schema
etc. – please verify if I made any wrong assumptions 🙌Some extra stuff:
CompletionItem.preselected
fromOption<bool>
to a simplebool
ClauseType
enumNote: I had to comment out an alphanumeric table test. The query generates a tree-sitter tree with an
ERROR
, and the current node has anend_byte()
that is at position 17, while the query only has a length of 14... will check in a separate PR, not sure why it even worked before 🤷