Skip to content

fix: infinite dataloader reset on every baseParams change #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DorianMaliszewski
Copy link
Member

No description provided.

@DorianMaliszewski DorianMaliszewski self-assigned this May 15, 2025
Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 298a2fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scaleway/use-dataloader Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (67c4699) to head (298a2fc).

Files with missing lines Patch % Lines
...ckages/use-dataloader/src/useInfiniteDataLoader.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   78.40%   78.35%   -0.05%     
==========================================
  Files          26       26              
  Lines         875      873       -2     
  Branches      114      115       +1     
==========================================
- Hits          686      684       -2     
  Misses        174      174              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants