Intellij uses the native image from .gradle/palantir-java-formatter-caches
#1306
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| type: fix | ||
| fix: | ||
| description: Intellij uses the native image from `.gradle/palantir-java-formatter-caches` | ||
| links: | ||
| - https://github.com/palantir/palantir-java-format/pull/1306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * (c) Copyright 2025 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.javaformat.gradle; | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.util.Comparator; | ||
| import java.util.stream.Stream; | ||
|
|
||
| public final class FileUtils { | ||
|
|
||
| public static void delete(Path path) { | ||
| if (!Files.exists(path)) { | ||
| return; | ||
| } | ||
| if (Files.isDirectory(path)) { | ||
| deleteDirectory(path); | ||
| } else { | ||
| deleteFile(path); | ||
| } | ||
| } | ||
|
|
||
| private static void deleteDirectory(Path dir) { | ||
| try (Stream<Path> paths = Files.walk(dir)) { | ||
| paths.sorted(Comparator.reverseOrder()).forEach(FileUtils::deleteFile); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to delete directory", e); | ||
| } | ||
| } | ||
|
|
||
| private static void deleteFile(Path targetPath) { | ||
| try { | ||
| Files.delete(targetPath); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(String.format("Failed to delete path %s", targetPath), e); | ||
| } | ||
| } | ||
|
|
||
| private FileUtils() {} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /* | ||
| * (c) Copyright 2025 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.javaformat.gradle; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.net.URI; | ||
| import java.nio.channels.FileChannel; | ||
| import java.nio.file.AtomicMoveNotSupportedException; | ||
| import java.nio.file.FileAlreadyExistsException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
| import java.nio.file.StandardCopyOption; | ||
| import java.nio.file.StandardOpenOption; | ||
| import java.util.Optional; | ||
| import org.gradle.api.logging.Logger; | ||
| import org.gradle.api.logging.Logging; | ||
|
|
||
| public class NativeImageAtomicCopy { | ||
|
|
||
| private static Logger logger = Logging.getLogger(PalantirJavaFormatIdeaPlugin.class); | ||
|
|
||
| public static URI copyToCacheDir(URI srcUri, File cacheDir) { | ||
| Path src = Paths.get(srcUri); | ||
| Path dst = cacheDir.toPath().resolve(src.getFileName()); | ||
| if (Files.exists(dst)) { | ||
| logger.info("Native image at path {} already exists", dst); | ||
| return dst.toUri(); | ||
| } | ||
| Path lockFile = dst.getParent().resolve(dst.getFileName() + ".lock"); | ||
| try (FileChannel channel = FileChannel.open( | ||
| lockFile, StandardOpenOption.READ, StandardOpenOption.CREATE, StandardOpenOption.WRITE)) { | ||
| channel.lock(); | ||
| // double-check, now that we hold the lock | ||
| if (Files.exists(dst)) { | ||
| logger.info("Native image at path {} already exists", dst); | ||
| return dst.toUri(); | ||
| } | ||
| try { | ||
| // Attempt an atomic move first to avoid broken partial states. | ||
| // Failing that, we use the replace_existing option such that | ||
| // the results of a successful move operation are consistent. | ||
| // This provides a helpful property in a race where the slower | ||
| // process doesn't risk attempting to use the native image before | ||
| // it has been fully moved. | ||
| Path tempCopyDir = Files.createTempDirectory("tempDir"); | ||
| Path tmpFile = tempCopyDir.resolve(src.getFileName()); | ||
| try { | ||
| Files.copy(src, tmpFile, StandardCopyOption.REPLACE_EXISTING); | ||
| Files.move(tmpFile, dst, StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.ATOMIC_MOVE); | ||
| } catch (AtomicMoveNotSupportedException ignored) { | ||
| Files.move(tmpFile, dst, StandardCopyOption.REPLACE_EXISTING); | ||
| } finally { | ||
| FileUtils.delete(tempCopyDir); | ||
| } | ||
| } catch (FileAlreadyExistsException e) { | ||
| // This means another process has successfully installed this native image, and we can just use theirs. | ||
| // Should be unreachable using REPLACE_EXISTING, however kept around to prevent issues with potential | ||
| // future refactors. | ||
| } | ||
| return dst.toUri(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(String.format("Failed to copy the native image to path %s", dst), e); | ||
| } | ||
| } | ||
|
|
||
| private static Path getGradleCacheDir() { | ||
| return Path.of(Optional.ofNullable(System.getenv("GRADLE_USER_HOME")) | ||
| .orElseGet(() -> System.getenv("HOME") + "/.gradle")); | ||
|
Comment on lines
+83
to
+84
There was a problem hiding this comment. I think we can use |
||
| } | ||
|
|
||
| private NativeImageAtomicCopy() {} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * (c) Copyright 2025 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.javaformat.gradle; | ||
|
|
||
| import java.io.File; | ||
| import java.net.URI; | ||
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
| import org.gradle.api.DefaultTask; | ||
| import org.gradle.api.file.ConfigurableFileCollection; | ||
| import org.gradle.api.file.RegularFileProperty; | ||
| import org.gradle.api.tasks.Classpath; | ||
| import org.gradle.api.tasks.InputFiles; | ||
| import org.gradle.api.tasks.Optional; | ||
| import org.gradle.api.tasks.OutputDirectory; | ||
| import org.gradle.api.tasks.OutputFile; | ||
| import org.gradle.api.tasks.TaskAction; | ||
|
|
||
| public abstract class UpdatePalantirJavaFormatIdeaXmlFile extends DefaultTask { | ||
|
|
||
| @InputFiles | ||
| @Classpath | ||
| public abstract ConfigurableFileCollection getImplementationConfig(); | ||
|
|
||
| @Optional | ||
| @InputFiles | ||
| public abstract ConfigurableFileCollection getNativeImageConfig(); | ||
|
|
||
| @Optional | ||
| @OutputFile | ||
| public abstract RegularFileProperty getOutputFile(); | ||
|
|
||
| @OutputDirectory | ||
| public abstract RegularFileProperty getCacheDir(); | ||
|
|
||
| @TaskAction | ||
| public final void updateXml() { | ||
| List<URI> uris = | ||
| getImplementationConfig().getFiles().stream().map(File::toURI).collect(Collectors.toList()); | ||
| java.util.Optional<URI> nativeUri = getNativeImageConfig().isEmpty() | ||
| ? java.util.Optional.empty() | ||
| : java.util.Optional.of(getNativeImageConfig().getSingleFile().toURI()) | ||
| .map(uri -> NativeImageAtomicCopy.copyToCacheDir( | ||
| uri, getCacheDir().getAsFile().get())); | ||
| XmlUtils.updateIdeaXmlFile( | ||
| getOutputFile().getAsFile().get(), | ||
| node -> ConfigureJavaFormatterXml.configureJavaFormat(node, uris, nativeUri)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in gradle-jdks