Skip to content

ci(benchmark): wait for base branch benchmark run to complete #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 30, 2025

This PR introduces a new job to the benchmark workflow to ensure the base branch's benchmark run has completed before starting the current benchmark.

This is important for benchmarking because the current branch's benchmark would compare with the base branch's benchmark result. When we create some PRs at the same time, the current branch's benchmark may be done before the base branch's benchmark; no benchmark can be compared, and the benchmark result would show N/A

The benchmark graph is like:
image

See https://github.com/oxc-project/oxc/actions/runs/14749573518?pr=10710

NOTE: The code was generated by the Gemini 2.5 Pro AI. I just told him what I thought and verified the code to see if it works.

Copy link
Member Author

Dunqing commented Apr 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 04-30-ci_benchmark_wait_for_base_branch_benchmark_run_to_succeed branch 3 times, most recently from b216b82 to 2bca7a2 Compare April 30, 2025 07:23
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Instrumentation Performance Report

Merging #10708 will not alter performance

Comparing 04-30-ci_benchmark_wait_for_base_branch_benchmark_run_to_succeed (0f7d70d) with main (9e557cf)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-30-ci_benchmark_wait_for_base_branch_benchmark_run_to_succeed branch 3 times, most recently from ee739d5 to 948f73f Compare April 30, 2025 07:53
@Dunqing Dunqing marked this pull request as ready for review April 30, 2025 12:27
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the benchmark job waits until the base branch's benchmark run has been completed before proceeding, enabling an accurate comparison between the two runs.

  • Introduces a new job ("check-base-benchmark") that monitors the latest workflow run on the base branch.
  • Updates subsequent jobs ("benchmark" and "benchmark-linter") to depend on the new job, ensuring proper sequencing.

@Dunqing Dunqing force-pushed the 04-30-ci_benchmark_wait_for_base_branch_benchmark_run_to_succeed branch from 948f73f to d8fcaf6 Compare April 30, 2025 12:28
@Dunqing Dunqing force-pushed the 04-30-ci_benchmark_wait_for_base_branch_benchmark_run_to_succeed branch from c346ce9 to 0f7d70d Compare April 30, 2025 12:30
@Dunqing Dunqing changed the title ci(benchmark): wait for base branch benchmark run to succeed ci(benchmark): wait for base branch benchmark run to complete Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants