-
-
Notifications
You must be signed in to change notification settings - Fork 568
ci(benchmark): wait for base branch benchmark run to complete #10708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci(benchmark): wait for base branch benchmark run to complete #10708
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
b216b82
to
2bca7a2
Compare
CodSpeed Instrumentation Performance ReportMerging #10708 will not alter performanceComparing Summary
|
ee739d5
to
948f73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that the benchmark job waits until the base branch's benchmark run has been completed before proceeding, enabling an accurate comparison between the two runs.
- Introduces a new job ("check-base-benchmark") that monitors the latest workflow run on the base branch.
- Updates subsequent jobs ("benchmark" and "benchmark-linter") to depend on the new job, ensuring proper sequencing.
948f73f
to
d8fcaf6
Compare
c346ce9
to
0f7d70d
Compare
This PR introduces a new job to the benchmark workflow to ensure the base branch's benchmark run has completed before starting the current benchmark.
This is important for benchmarking because the current branch's benchmark would compare with the base branch's benchmark result. When we create some PRs at the same time, the current branch's benchmark may be done before the base branch's benchmark; no benchmark can be compared, and the benchmark result would show
N/A
The benchmark graph is like:

See https://github.com/oxc-project/oxc/actions/runs/14749573518?pr=10710
NOTE: The code was generated by the Gemini 2.5 Pro AI. I just told him what I thought and verified the code to see if it works.