Skip to content

feature and refactor: add lombok, introduce package structure and add interface to configure dependent resources #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
import io.javaoperatorsdk.operator.api.config.ConfigurationService;
import io.javaoperatorsdk.operator.api.config.ConfigurationServiceOverrider;
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
import io.javaoperatorsdk.operator.springboot.starter.OperatorConfigurationProperties;
import io.javaoperatorsdk.operator.springboot.starter.ReconcilerProperties;
import io.javaoperatorsdk.operator.springboot.starter.properties.OperatorConfigurationProperties;
import io.javaoperatorsdk.operator.springboot.starter.properties.ReconcilerProperties;
import io.javaoperatorsdk.operator.springboot.starter.sample.CustomService;
import io.javaoperatorsdk.operator.springboot.starter.sample.CustomServiceReconciler;
import io.javaoperatorsdk.operator.springboot.starter.sample.ServiceSpec;
Expand Down
6 changes: 6 additions & 0 deletions starter/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@
</developers>

<dependencies>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.36</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-autoconfigure-processor</artifactId>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package io.javaoperatorsdk.operator.springboot.starter;

@FunctionalInterface
public interface DependentResourceConfigurator {

String getName();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note regarding to this, altevatively we could avoid inheritance, so the configuration bean would not inherit this interface, but we could put here also method getConfiguraiton that would result in the configuration bean.
But no strong opinion one way or another.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or as an atlernative we could have this just as an annotation on top of a conig bean: @DependentConfiguration(dependentName="dr name", reconcilerName="optional reconciler name")


}

This file was deleted.

Loading
Loading