Skip to content

feat: multi cluster InformerEventSource support #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 72 commits into from
Closed

feat: multi cluster InformerEventSource support #2495

wants to merge 72 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Aug 13, 2024

No description provided.

csviri and others added 30 commits August 8, 2024 09:39
@csviri
chore: set version to 5.0.0-SNAPSHOT (#2200)
de1ba28 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: java version minimal 11, tested on 21 (#2207)
82e4632 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated EventFilter (#2208)
30e233c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: 5.0 migration guide skeleton (#2210)
8ff4cee 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: managed dependent reconciliation results not optional (#2212)
77a3eee 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated RetryConfiguration (#2211)
15c2661 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: JDK client is now the default (#2235)
32f4c3a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
fix: update SCM information (#2237)
affdd07 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
128499a 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
format
af9311a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: test after rebase on master (#2270)
5ca2afa 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: use java 17 as baseline (#2271)
c3ce02e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: matcher always considers metadata (#2273)
c5a7a77 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: API to check if next reconciliation is imminent (#2272)
5ab13d4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: Workflow extracted to a separate annotation (#2274)
3794bea 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: pom properties cleanup (#2280)
4138c9c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
658f3f6 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: make loadFromProperties private (#2287)
ab5a827 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: distinguish resources based on desired state (#2252)
6e4cf34 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: explicit workflow invocation (#2289)
c0d687b 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: use ssa for status update by default from UpdateControl (#2278)
8e6a18e 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: make WorkflowSpec an interface (#2300)
7cb4302 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: replace current formatting plugins with spotless plugin (#2302)
6108f9b 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
5d4e9fc 
…2308)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: package fix leader election sample (#2303)
67b3b31 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: remove resource discriminator (#2299)
1edfc8c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
c083dd4 
…ed (#2297)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: additional logging to mysql schema e2e test (#2320)
41dc0f6 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
170774d 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: using SSA for finalizer and primary patch (#2305)
d8e2636 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm and others added 15 commits August 8, 2024 09:41
@metacosm @csviri
fix: improper javadoc preventing release (#2450)
444a538 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
docs: use docs dir instead of docsy (#2443)
de824d7 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: move getResourceClassResolver to BaseConfigurationService (#…
f49afea 
…2451)

The class resolving mechanism is only needed in that class right now

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
feat: @ControllerConfiguration annotation is optional (#2412)
19ebdb2 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
bump: chore use slf4j v2 (#2406)
1031300 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: integration test to show multiple dependents with activation co…
0865103 
…ndition (#2454)


Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
refactor: updateMatcher removal (#2431)
811964f
@metacosm @csviri
chore(docs): add some javadoc (#2452)
bfa756a 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
fix: improper use of @link (#2464)
c8ef10d 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
feat: move controller informer-related configuration to InformerConfig (
eabdb20 
#2455)

* feat: move controller informer-related configuration to InformerConfig

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: start isolating ResourceConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: initFromAnnotation now properly inits the current instance

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: default onDeleteFilter implementation

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: properly set default namespaces in controller case

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: remove KubernetesDependentInformerConfigBuilder

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: use InformerConfigHolder in more places, unifying handling

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: properly propagate name to informer config

Signed-off-by: Chris Laprun <claprun@redhat.com>

* feat: add factory method to init builder from an extising configuation

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: remove potentially problematic default implementation

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
feat: allow returning additional information from conditions (#2426)
657301f 
Fixes #2424.

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
@10000-ki @csviri
feat: support for graceful shutdown based on configuration (#2479)
dd104ab 
---------

Signed-off-by: 10000-ki <10000ki6472@gmail.com>
@csviri @metacosm
refactor: move integration tests to feature packages and sub packages…
02b876b 
… based on type (#2483)

* refactor: integration tests moved to feature packages and sub packages pased on type

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fix resource paths

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* link and test fixes

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* format

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* wip

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* old service

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* test fix

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

* refactor: remove unneeded classes

Signed-off-by: Chris Laprun <claprun@redhat.com>

* fix: typo in package name

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@metacosm @csviri
refactor: clean up informer configuration classes (#2470)
a6621c2 
* chore: set version to 5.0.0-SNAPSHOT (#2200)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* improve: replace current formatting plugins with spotless plugin  (#2302)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* fix: format after rebase

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* bump: chore use slf4j v2 (#2406)

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* feat: allow returning additional information from conditions (#2426)

Fixes #2424.

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: move @InformerConfig to more appropriate package

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: move InformerConfigHolder to appropriate package

Signed-off-by: Chris Laprun <claprun@redhat.com>

* chore: remove unneeded code & dependencies

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: InformerConfiguration to InformerEventSourceConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename inner InformerConfigurationBuilder to simply Builder

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename InformerConfig and associated field to Informer

Signed-off-by: Chris Laprun <claprun@redhat.com>

* refactor: rename InformerConfigHolder to InformerConfiguration

Signed-off-by: Chris Laprun <claprun@redhat.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
@csviri
feat: support to handle different cluster for InformerEventSource
fdd96b5 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
@csviri csviri changed the base branch from main to next August 13, 2024 15:18
@csviri csviri linked an issue Aug 13, 2024 that may be closed by this pull request
Support different clusters with InformerEventSource #2493
Closed
@csviri
docs
3ea8aa1 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
csviri added 2 commits August 13, 2024 17:51
@csviri
format
3e3c118 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
wip
a7087fa 
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri self-assigned this Aug 15, 2024
@csviri
Copy link
Collaborator Author

csviri commented Aug 15, 2024

replaced by: #2499

@csviri csviri closed this Aug 15, 2024
@metacosm
Copy link
Collaborator

Should we delete this branch?

@csviri csviri deleted the multi-cluster-informer-es branch August 15, 2024 09:19
@csviri
Copy link
Collaborator Author

csviri commented Aug 15, 2024

deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@csviri csviri

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support different clusters with InformerEventSource
4 participants
@csviri @metacosm @openshift-merge-robot @10000-ki