Update linter version and install instructions in README.md #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only visible change is that the mdatagen issue is now linked. All the rest of these are just markdownlint recommendations.
This should fail the local inner test, not the parent.
`make unit-test` was failing on tests for parsing hostinfo. E.g.
- VersionId: (string) (len=5) "22.04",
- Version: (string) (len=29) "22.04.5 LTS (Jammy Jellyfish)",
+ VersionId: (string) (len=5) "24.04",
+ Version: (string) (len=26) "24.04.2 LTS (Noble Numbat)",
My host system (where make is running) is Ubuntu 24.04.2 LTS (Noble
Numbat) so it picking that up.
After tracing this through I found that
- The test is mocking what releaseinfo should return: internal/datasource/host/info_test.go#L518
- mock is consumed at internal/datasource/host/info.go#L298
- but then, internal/datasource/host/info.go#L299-L306
- readOsRelease info (which is different than the "host"?)
- if this errors returns the mocked hostReleaseInfo, e.g. on mac
- if this returns data (my ubuntu host) it is merged into the returned data
It looks like these tests generally haven't been run on a host that
has `/etc/os-release` and tests shouldn't be subject to host system
data changes like that.
I've just put in a bad path so that on ubuntu hosts it won't read
anything; this should match the existing behavior of running this on
macos hosts.
When the local go toolchain is go1.24 or newer make lint reports a bunch of spurious errors. This newer version of golangci-lint is compatible with go1.24 eliminating that. - `context` config changed, there are now more options than true or false. "" disables it to match the previous behavior - `exported-is-used` is deprecated, it is always true now.
github-actions
bot
added
bug
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
recheck |
|
I have hereby read the F5 CLA and agree to its terms |
puneetsarna
reviewed
May 17, 2025
puneetsarna
reviewed
May 17, 2025
puneetsarna
approved these changes
May 17, 2025
puneetsarna
reviewed
May 17, 2025
puneetsarna
reviewed
May 17, 2025
dhurley
approved these changes
May 21, 2025
dhurley
changed the title
aphralG
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Without these changes I can't develop on v3 reliably; the
make lint unit-testand the pre-push scripts fail. See the individual commits for more details of what/why they do.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)make teston Ubuntu 24.04 and doubt anyone has run make test on any of the above listed platforms recently because any distro that has an/etc/os-releasethat doesn't exactly match the test expectation will fail.