refactor：简化头像计算，新增头像最大尺寸参数，避免头像裁剪出来太大 || refactor: Simplify the avatar calculation and add a new avatar. Maximum size parameter to prevent the avatar from being cropped too large #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tailchat-nightly ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
changed the title
moonrailgun
reviewed
Jan 11, 2024
| 0, | ||
| 0, | ||
| size, | ||
| size | ||
| ); |
There was a problem hiding this comment.
This function is design for common image cropper not only for avatar. for example: group background.
maybe you can check component in client/web/src/components/ImageUploader.tsx#AvatarUploader
|
I dont know why you continue wanna change algorithm This pr has two problem:
if you can not cover it, free feel to tell me, i can merge it and change this logic work fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用的时候遇到提示文件太大，但是手机上的照片动辄10m+,优化了一下裁剪头像，现在选择本地图片可以选择更大的图片了
When using it, I encountered a prompt that the file is too large, but the photos on the mobile phone are often 10m+. I have optimized the cropped avatar. Now you can choose a larger image when selecting a local image.