Skip to content

CLOUDP-319858: Auto-update SBOM report in codebase #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
May 22, 2025
Merged

CLOUDP-319858: Auto-update SBOM report in codebase #3902

merged 30 commits into from
May 22, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented May 21, 2025

Proposed changes

Jira ticket: CLOUDP-319858

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master 4e33829 25.1%
CLOUDP-319858 4882767 25.1%
Difference 0%

@blva blva marked this pull request as ready for review May 21, 2025 17:15
@blva blva requested a review from a team as a code owner May 21, 2025 17:15
Comment on lines +37 to +41
- name: Run gen-ssdlc-report.sh
env:
AUTHOR: ${{ steps.extract.outputs.author }}
VERSION: ${{ steps.extract.outputs.version }}
run: ./build/package/gen-ssdlc-report.sh
Copy link
Collaborator

@andreaangiolillo andreaangiolillo May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a risk that gen-ssdlc-report.sh run on a codebase that no longer reflect the tag? What I mean here is that I don't see any step where you are getting the CLI codebase at the release tag so the ssdlc report may includes code changes that were merged after the release tag was created.

[solution] I think you should update the checkout step to download the codebase at the release tag

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes code changes that were merged after the release tag was created.

good point, but since the report simply links to the tag link I think it will always show the sbom report that was generated upon tag release, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I don't know what gen-ssdlc-report.sh does 😅 Feel free to ignore the comment if the script does not actually do anything related to the codebase.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for now, but its a good point! thanks

@blva blva requested a review from andreaangiolillo May 22, 2025 11:01
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit 15865d9 into master May 22, 2025
22 of 23 checks passed
@blva blva deleted the CLOUDP-319858 branch May 22, 2025 11:23
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Moving the report on-release to a GH action should make for a great foundation for the on-demand augmented report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants