-
Notifications
You must be signed in to change notification settings - Fork 85
CLOUDP-319858: Auto-update SBOM report in codebase #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report 📈
|
- name: Run gen-ssdlc-report.sh | ||
env: | ||
AUTHOR: ${{ steps.extract.outputs.author }} | ||
VERSION: ${{ steps.extract.outputs.version }} | ||
run: ./build/package/gen-ssdlc-report.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a risk that gen-ssdlc-report.sh run on a codebase that no longer reflect the tag? What I mean here is that I don't see any step where you are getting the CLI codebase at the release tag so the ssdlc report may includes code changes that were merged after the release tag was created.
[solution] I think you should update the checkout step to download the codebase at the release tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
includes code changes that were merged after the release tag was created.
good point, but since the report simply links to the tag link I think it will always show the sbom report that was generated upon tag release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I don't know what gen-ssdlc-report.sh
does 😅 Feel free to ignore the comment if the script does not actually do anything related to the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for now, but its a good point! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Moving the report on-release to a GH action should make for a great foundation for the on-demand augmented report!
Proposed changes
Jira ticket: CLOUDP-319858
compliance
folder : e.g.compliance/v1.42.2/
Checklist
make fmt
and formatted my codeFurther comments