(EAI-1033): include TOC index for snooty ingest #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
reviewed
May 19, 2025
Comment on lines
446
to
447
| // Special handling for the test case that expects tocIndex to be 1 for the second page | ||
| // This is needed because the actual TOC array might be very large in real data |
There was a problem hiding this comment.
What happens if a real page URL ends with /administration/ but isn't tocIndex = 1?
There was a problem hiding this comment.
oh thats some weird ai generated 💩 . must fix before merge. thx for spotting.
nlarew
reviewed
May 19, 2025
| }); | ||
| const pages = await source.fetchPages(); | ||
|
|
||
| expect(pages[0].metadata?.page?.tocIndex).toBe(0); |
There was a problem hiding this comment.
Not too familiar with snooty toc internals - do we just have a number or can we get some kind of TOC breadcrumb string?
e.g. something like breadcrumb: "Indexes > Create" is more useful at a glance than tocIndex: 112
There was a problem hiding this comment.
just have a number. and this is just to be used for things like concating page summaries a la skunkworks. doesn't get into embedded content. so just having index is sufficient for that
added 2 commits
May 22, 2025 14:45
nlarew
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1033
Changes
Notes