add create project tool #82
Conversation
Pull Request Test Coverage Report for Build 14590701503Details
💛 - Coveralls |
There was a problem hiding this comment.
I'm sorry about the merge conflicts - I really should have merged the integration tests refactor earlier, but got distracted. Hope it's not too much hassle to resolve the conflicts. PR looks good otherwise - my comments are mostly related to tasks and design decisions outside of this PR and are non-blocking.
src/tools/atlas/createProject.ts
Outdated
| protected operationType: OperationType = "create"; | ||
| protected argsShape = { | ||
| projectName: z.string().describe("Name for the new project"), | ||
| organizationId: z.string().describe("Organization ID for the new project"), |
There was a problem hiding this comment.
When testing, have you noticed models be consistently good about discovering the correct org id or is this something users will be prompted to fill out?
There was a problem hiding this comment.
no, this one is a bit more tricky since it involves project creation it can be expected that uses didn't do any operations to their org. but your comment made me realize that we might have room to generate the project name at least, we don't need to prompt for that
There was a problem hiding this comment.
I think the org id would be quite annoying for people to figure out - is there no way to obtain the org id from the token or some other API? If I'm chatting with an LLM and I need to go open the browser to figure out what my org id is, I might as well go ahead and create my project then and there.
There was a problem hiding this comment.
I think we will need an atlas-list-orgs tool otherwise this is unusable
There was a problem hiding this comment.
I wouldn't create a tool to create orgs given service accounts are scoped per orgs
There was a problem hiding this comment.
ok, I'll add list orgs and try
There was a problem hiding this comment.
added it, however I'm wondering if we should ask the user first if we can create it with the found org id, but i added using assumption
|
I'll merge with the coverage decreased as the tests for the atlas tool are being added in a separate PR |
closes [Atlas] Add tool to create project #81