Add external DNS disclaimer for DS records #2506
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rebased and reworded version of this PR: mail-in-a-box#1920
|
I don't think it's correct, though. If you are using External DNS, you don't need to resolve the issue because it is not relevant. And as I think I said in the other PR, there are many status checks that aren't relevant when using External DNS. I would rather have this be consistent for all status checks, otherwise it may create more confusion. |
|
Is there any plans to implement a switch to disable these? As previously mentioned it can be somewhat confusing to have this many errors which could potentially be hiding other actual errors, I think that it is preferable to at least have a disclaimer to avoid pointless worry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and reworded version of this PR: #1920