test(spec): move spec test runners to test folder (#699)

Author: mpaulucci

Makefile

@@ -160,7 +160,7 @@ $(VECTORS_DIR)/%: $(SPECTEST_ROOTDIR)/%_${SPECTEST_VERSION}.tar.gz
 	-rm -rf $@
 	tar -xzmf "$<" -C $(SPECTEST_ROOTDIR)
 
-$(SPECTEST_GENERATED_ROOTDIR): $(VECTORS_DIR)/mainnet $(VECTORS_DIR)/minimal $(VECTORS_DIR)/general lib/spec/runners/*.ex lib/mix/tasks/generate_spec_tests.ex
+$(SPECTEST_GENERATED_ROOTDIR): $(VECTORS_DIR)/mainnet $(VECTORS_DIR)/minimal $(VECTORS_DIR)/general test/spec/runners/*.ex test/spec/tasks/*.ex
 	mix generate_spec_tests
 
 #⬇️ download-vectors: @ Download the spec test vectors files.

lib/lambda_ethereum_consensus/p2p/block_downloader.ex

@@ -50,7 +50,6 @@ defmodule LambdaEthereumConsensus.P2P.BlockDownloader do
          {:ok, chunks} <- parse_response(response_chunk),
          {:ok, blocks} <- decode_chunks(chunks),
          :ok <- verify_batch(blocks, slot, count) do
-      # TODO: handle cases where slot is empty
       tags = %{result: "success", type: "by_slot", reason: "success"}
       :telemetry.execute([:network, :request], %{blocks: count}, tags)
       {:ok, blocks}

mix.exs

@@ -12,7 +12,8 @@ defmodule LambdaEthereumConsensus.MixProject do
       elixirc_paths: compiler_paths(Mix.env()),
       warn_test_pattern: "_remove_warning.exs",
       preferred_cli_env: [
-        dialyzer: :test
+        dialyzer: :test,
+        generate_spec_tests: :test
       ]
     ]
   end
@@ -69,6 +70,8 @@ defmodule LambdaEthereumConsensus.MixProject do
     ]
   end
 
-  defp compiler_paths(:test), do: ["test/spec", "test/fixtures"] ++ compiler_paths(:prod)
+  defp compiler_paths(:test),
+    do: ["test/spec", "test/fixtures"] ++ compiler_paths(:prod)
+
   defp compiler_paths(_), do: ["lib", "proto"]
 end

lib/spec/runner_behaviour.ex renamed to test/spec/runner_behaviour.ex

@@ -16,7 +16,7 @@ defmodule Mix.Tasks.GenerateSpecTests do
   @shortdoc "Generates tests for spec test files"
   @impl Mix.Task
   def run(_args) do
-    {:ok, file_names} = File.ls(Path.join(["lib", "spec", "runners"]))
+    {:ok, file_names} = File.ls(Path.join(["test", "spec", "runners"]))
     runners = Enum.map(file_names, &Path.basename(&1, ".ex"))
 
     # Generate all tests for Capella fork