test(spec): move spec test runners to test folder #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us into move-runners-to-test
mpaulucci
commented
Jan 30, 2024
| @@ -50,7 +50,6 @@ defmodule LambdaEthereumConsensus.P2P.BlockDownloader do | |||
| {:ok, chunks} <- parse_response(response_chunk), | |||
| {:ok, blocks} <- decode_chunks(chunks), | |||
| :ok <- verify_batch(blocks, slot, count) do | |||
| # TODO: handle cases where slot is empty | |||
There was a problem hiding this comment.
unrelated, but this comment doesn't apply anymore.
mpaulucci
commented
Jan 30, 2024
| @@ -12,7 +12,8 @@ defmodule LambdaEthereumConsensus.MixProject do | |||
| elixirc_paths: compiler_paths(Mix.env()), | |||
| warn_test_pattern: "_remove_warning.exs", | |||
| preferred_cli_env: [ | |||
| dialyzer: :test | |||
| dialyzer: :test, | |||
| generate_spec_tests: :test | |||
There was a problem hiding this comment.
this is the main change, running the task in :test env so that the runners are included as part of the compilation.
mpaulucci
force-pushed
the
move-runners-to-test
branch
from
fc1135e to
d98a143
Compare
Arkenan
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We shouldn't have test runner code in our lib folder. I understand that we did this because we thought there was no other way, but there is.