Skip to content

Fix Linux Node Exporter #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix Linux Node Exporter #3305

wants to merge 2 commits into from
+78 −93

Conversation

MikeZappa87
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MikeZappa87
Once this PR has been reviewed and has the lgtm label, please assign wojtek-t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t April 25, 2025 17:12
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2025
MikeZappa87
MikeZappa87 commented Apr 25, 2025
View reviewed changes
clusterloader2/pkg/prometheus/manifests/exporters/node_exporter/node-exporter-daemonset.yaml
hostPID: true
containers:
- name: node-exporter
image: quay.io/prometheus/node-exporter:latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a tag, not latest

MikeZappa87
MikeZappa87 commented Apr 25, 2025
View reviewed changes
clusterloader2/pkg/prometheus/manifests/exporters/node_exporter/node-exporter-daemonset.yaml
image: quay.io/prometheus/node-exporter:latest
args:
- "--path.procfs=/host/proc"
- "--path.sysfs=/host/sys"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure out what people want to collect

@MikeZappa87 MikeZappa87 force-pushed the mzappa/fixnodeexporter branch from a90acf5 to 6f079e3 Compare April 25, 2025 17:17
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2025
@MikeZappa87 MikeZappa87 force-pushed the mzappa/fixnodeexporter branch from 6f079e3 to 4f8da95 Compare April 25, 2025 17:19
@MikeZappa87 MikeZappa87 force-pushed the mzappa/fixnodeexporter branch from 4f8da95 to c627004 Compare April 25, 2025 17:30
MikeZappa87
MikeZappa87 commented Apr 25, 2025
View reviewed changes
clusterloader2/pkg/prometheus/prometheus.go
numMasters := 0
for _, node := range nodes {
node := node
if util.LegacyIsMasterNode(&node) || util.IsControlPlaneNode(&node) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do cloud environments even give access to the control plane nodes?

Copy link
Contributor Author

@MikeZappa87 MikeZappa87 Apr 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can understand the motivation for this to be a static pod however should we maintain this requirement? It's not hard to keep the daemonset and the static pods but they should be enabled with separate flags. What do we gain with these being static pods if the rest of the pods haven't been scheduled yet such as prometheus? It's probably safe to just use the daemonset.

@MikeZappa87
Copy link
Contributor Author

@wojtek-t do you have any thoughts here?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2025
@MikeZappa87 MikeZappa87 force-pushed the mzappa/fixnodeexporter branch from 0a13adb to 9494254 Compare April 29, 2025 13:16
@MikeZappa87 MikeZappa87 force-pushed the mzappa/fixnodeexporter branch from 9494254 to b9e328f Compare April 29, 2025 13:20
@MikeZappa87
Copy link
Contributor Author

@wojtek-t do you have any thoughts here?

@mborsz maybe you have some ideas here? Or the backstory

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeZappa87 @k8s-ci-robot