conformance test: CORS #3739

zhaohuabing · 2025-04-09T02:25:09Z

What type of PR is this?
/kind test
/area conformance-test

What this PR does / why we need it:
This PR adds conformance tests for HTTPCORSFilter.

Which issue(s) this PR fixes:

Related #3649

Does this PR introduce a user-facing change?:

None

k8s-ci-robot · 2025-04-09T02:25:11Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-04-09T02:25:18Z

Hi @zhaohuabing. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-04-09T02:27:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhaohuabing
Once this PR has been reviewed and has the lgtm label, please assign shaneutt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing · 2025-05-06T04:01:47Z

Hi @mikemorris @sunjayBhatia @youngnick Is there anything I can do to help the review? This is the first time creating a conformance test PR, so there is a good chance I may have missed something that's blocking the review. Please feel free to let me know if there's anything I can address. Thanks!

cc @arkodg

pkg/features/httproute.go

conformance/tests/httproute-cors.yaml

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

conformance/tests/httproute-cors.go

snorwin · 2025-05-15T07:58:07Z

conformance/tests/httproute-cors.go

+					Headers: map[string]string{
+						"Origin":                         "https://www.bar.com",
+						"access-control-request-method":  "GET",
+						"access-control-request-headers": "x-header-1, x-header-2",


According to the specification (https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1/httproute_types.go#L1386), headers (and also methods) are separated by "," instead of ", ".

I've tested this against Envoy Gateway, and the methods in the access-control-request-headers header are separated by ", ". Also, the example in https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Access-Control-Allow-Methods contains whitespaces.

Access-Control-Allow-Methods: PUT, DELETE

Maybe we are both right and the whitespace is optional: https://httpwg.org/specs/rfc9110.html#rfc.section.5.3 (from https://fetch.spec.whatwg.org/#http-new-header-syntax)

Yeah, you're right. The test should accommodate both formats.

@snorwin I added an option to ignore the whitespace in the header value.

snorwin · 2025-05-15T08:02:20Z

@zhaohuabing I verified the new CORS tests against our implementation and identified a difference in how the access-control-request-headers is mapped. See the comment here: #3739 (comment).

Just a heads-up: depending on the outcome of #3648, the tests might need to be adapted or extended accordingly.

Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

snorwin · 2025-05-15T11:11:02Z

@zhaohuabing lgtm, however, since I’m not part of the approvers, I’m unable to formally approve it.

zhaohuabing · 2025-05-21T11:05:22Z

Gentle ping @youngnick @sunjayBhatia @mikemorris — whenever you get a chance, would love your thoughts on this.

snorwin · 2025-05-29T10:36:41Z

/ok-to-test

zhaohuabing · 2025-05-30T02:37:58Z

/test pull-gateway-api-verify

conformance/utils/http/http.go

Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

zhaohuabing marked this pull request as draft April 9, 2025 02:25

k8s-ci-robot requested review from mikemorris and sunjayBhatia April 9, 2025 02:25

zhaohuabing force-pushed the cors-test branch from 51d1e15 to 1772aa1 Compare April 9, 2025 02:27

zhaohuabing changed the title ~~test: cors~~ conformance test: CORS Apr 9, 2025

zhaohuabing force-pushed the cors-test branch from 1772aa1 to 1cb6fac Compare April 9, 2025 02:51

add test for cors

1d639f0

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the cors-test branch from 1cb6fac to 1d639f0 Compare April 24, 2025 11:57

zhaohuabing marked this pull request as ready for review April 24, 2025 12:00

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2025

k8s-ci-robot requested a review from youngnick April 24, 2025 12:00

add more tests

aa41160

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the cors-test branch from d041501 to aa41160 Compare April 25, 2025 07:35

snorwin reviewed May 9, 2025

View reviewed changes

pkg/features/httproute.go Outdated Show resolved Hide resolved

snorwin mentioned this pull request May 9, 2025

conformance: initial draft for CORS filter tests #3740

Closed

2 tasks

snorwin reviewed May 9, 2025

View reviewed changes

conformance/tests/httproute-cors.yaml Show resolved Hide resolved

zhaohuabing added 2 commits May 14, 2025 07:54

address comment

f66c4e9

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

address comment

bc6f76b

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing requested a review from snorwin May 14, 2025 08:00

snorwin reviewed May 15, 2025

View reviewed changes

conformance/tests/httproute-cors.go Outdated Show resolved Hide resolved

snorwin reviewed May 15, 2025

View reviewed changes

conformance/tests/httproute-cors.go Outdated Show resolved Hide resolved

snorwin reviewed May 15, 2025

View reviewed changes

zhaohuabing and others added 2 commits May 15, 2025 17:33

Update conformance/tests/httproute-cors.go

4b43202

Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

Update conformance/tests/httproute-cors.go

33ed80c

Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

zhaohuabing force-pushed the cors-test branch 2 times, most recently from e6c17a3 to d0e2f9a Compare May 15, 2025 11:01

Add option to ignore whitespace in the resposnse header values

729ddcd

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>

zhaohuabing force-pushed the cors-test branch from d0e2f9a to 729ddcd Compare May 15, 2025 11:04

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2025

snorwin reviewed May 30, 2025

View reviewed changes

conformance/utils/http/http.go Outdated Show resolved Hide resolved

Update conformance/utils/http/http.go

6041c92

Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

conformance test: CORS #3739

Are you sure you want to change the base?

conformance test: CORS #3739

Conversation

zhaohuabing commented Apr 9, 2025

Uh oh!

k8s-ci-robot commented Apr 9, 2025

Uh oh!

k8s-ci-robot commented Apr 9, 2025

Uh oh!

k8s-ci-robot commented Apr 9, 2025

Uh oh!

zhaohuabing commented May 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snorwin May 15, 2025

Choose a reason for hiding this comment

Uh oh!

zhaohuabing May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snorwin May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhaohuabing May 15, 2025

Choose a reason for hiding this comment

Uh oh!

zhaohuabing May 15, 2025

Choose a reason for hiding this comment

Uh oh!

snorwin commented May 15, 2025

Uh oh!

snorwin commented May 15, 2025

Uh oh!

zhaohuabing commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snorwin commented May 29, 2025

Uh oh!

zhaohuabing commented May 30, 2025

Uh oh!

Uh oh!

Uh oh!

zhaohuabing May 15, 2025 •

edited

Loading

snorwin May 15, 2025 •

edited

Loading

zhaohuabing commented May 21, 2025 •

edited

Loading