Skip to content

Add ControllerServer.GetSnapshot CSI procedure #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nixpanic
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

The new ControllerServer.GetSnapshot CSI procedure has been added to the specification. This should be implemented in the csi-driver-hostpath so that other components can use it for testing.

Which issue(s) this PR fixes:

Related to kubernetes-csi/csi-test#573

Special notes for your reviewer:

Marked as Draft because there is no CSI spec release with the new GetSnapshot procedure yet.

Does this PR introduce a user-facing change?:

Add support for the new ControllerServer.GetSnapshot CSI procedure.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 28, 2025
@nixpanic
Copy link
Member Author

/test all

Nothing should break 🤞

@k8s-ci-robot
Copy link
Contributor

@nixpanic: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-28 a3e2af9 link false /test pull-kubernetes-csi-csi-driver-host-distributed-on-kubernetes-1-28
pull-kubernetes-csi-csi-driver-host-path-1-32-test-on-kubernetes-1-32 a3e2af9 link false /test pull-kubernetes-csi-csi-driver-host-path-1-32-test-on-kubernetes-1-32
pull-kubernetes-csi-csi-driver-host-path-1-31-test-on-kubernetes-1-31 a3e2af9 link false /test pull-kubernetes-csi-csi-driver-host-path-1-31-test-on-kubernetes-1-31
pull-kubernetes-csi-csi-driver-host-path-1-30-test-on-kubernetes-1-30 a3e2af9 link false /test pull-kubernetes-csi-csi-driver-host-path-1-30-test-on-kubernetes-1-30
pull-kubernetes-csi-csi-driver-host-path-1-30-on-kubernetes-1-30 a3e2af9 link true /test pull-kubernetes-csi-csi-driver-host-path-1-30-on-kubernetes-1-30
pull-kubernetes-csi-csi-driver-host-path-1-32-on-kubernetes-1-32 a3e2af9 link false /test pull-kubernetes-csi-csi-driver-host-path-1-32-on-kubernetes-1-32
pull-kubernetes-csi-csi-driver-host-path-1-31-on-kubernetes-1-31 a3e2af9 link true /test pull-kubernetes-csi-csi-driver-host-path-1-31-on-kubernetes-1-31

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nixpanic
Copy link
Member Author

nixpanic commented May 28, 2025

A panic happens:

+ kubectl logs csi-hostpathplugin-98n5w csi-provisioner
W0528 09:08:30.734604       1 feature_gate.go:354] Setting GA feature gate Topology=true. It will be removed in a future release.
I0528 09:08:30.734723       1 feature_gate.go:387] feature gates: {map[Topology:true]}
I0528 09:08:30.734762       1 csi-provisioner.go:166] "Version" version="v5.2.0"
I0528 09:08:30.734774       1 csi-provisioner.go:189] Building kube configs for running in cluster...
I0528 09:08:30.735052       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0528 09:08:30.735090       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0528 09:08:30.735099       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0528 09:08:30.735107       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0528 09:08:30.735787       1 connection.go:234] "Connecting" address="unix:///csi/csi.sock"
I0528 09:08:30.736893       1 common.go:143] "Probing CSI driver for readiness"
I0528 09:08:30.736926       1 connection.go:264] "GRPC call" method="/csi.v1.Identity/Probe" request="{}"
I0528 09:08:30.738315       1 connection.go:270] "GRPC response" response="{}" err=null
I0528 09:08:30.738392       1 connection.go:264] "GRPC call" method="/csi.v1.Identity/GetPluginInfo" request="{}"
I0528 09:08:30.739400       1 connection.go:270] "GRPC response" response="{\"name\":\"hostpath.csi.k8s.io\",\"vendor_version\":\"v1.16.0-20-g3fb2665\"}" err=null
I0528 09:08:30.739465       1 csi-provisioner.go:244] Detected CSI driver hostpath.csi.k8s.io
I0528 09:08:30.739486       1 connection.go:264] "GRPC call" method="/csi.v1.Identity/GetPluginCapabilities" request="{}"
I0528 09:08:30.740548       1 connection.go:270] "GRPC response" response="{\"capabilities\":[{\"service\":{\"type\":\"CONTROLLER_SERVICE\"}},{\"service\":{\"type\":\"GROUP_CONTROLLER_SERVICE\"}},{\"service\":{\"type\":\"VOLUME_ACCESSIBILITY_CONSTRAINTS\"}}]}" err=null
I0528 09:08:30.740602       1 connection.go:264] "GRPC call" method="/csi.v1.Controller/ControllerGetCapabilities" request="{}"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x1b8ae42]

goroutine 1 [running]:
github.com/kubernetes-csi/csi-lib-utils/protosanitizer.stripSingleValue({0x263df28, 0xc00031f680}, {{}, 0x1de98a0?, 0x0?, 0x1de9120?})
	/workspace/vendor/github.com/kubernetes-csi/csi-lib-utils/protosanitizer/protosanitizer.go:71 +0x82
github.com/kubernetes-csi/csi-lib-utils/protosanitizer.stripValue({0x263df28, 0xc00031f680}, {{}, 0x1de98a0?, 0x0?, 0xc0005029e8?})
	/workspace/vendor/github.com/kubernetes-csi/csi-lib-utils/protosanitizer/protosanitizer.go:94 +0x1b8
github.com/kubernetes-csi/csi-lib-utils/protosanitizer.stripMessage.func1({0x263df28, 0xc00031f680}, {{}, 0x1de98a0?, 0x0?, 0xc0002569d0?})
	/workspace/vendor/github.com/kubernetes-csi/csi-lib-utils/protosanitizer/protosanitizer.go:108 +0xdc
...

Reported kubernetes-csi/external-provisioner#1382 to get a release with the (already merged) fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants