-
Notifications
You must be signed in to change notification settings - Fork 219
Add ControllerServer.GetSnapshot CSI procedure #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nixpanic The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all Nothing should break 🤞 |
@nixpanic: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
A panic happens:
Reported kubernetes-csi/external-provisioner#1382 to get a release with the (already merged) fix. |
Waiting for kubernetes-csi/external-provisioner#1382 to be addressed too.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The new
ControllerServer.GetSnapshot
CSI procedure has been added to the specification. This should be implemented in the csi-driver-hostpath so that other components can use it for testing.Which issue(s) this PR fixes:
Related to kubernetes-csi/csi-test#573
Special notes for your reviewer:
Marked as Draft because there is no CSI spec release with the new
GetSnapshot
procedure yet.Does this PR introduce a user-facing change?: