Skip to content

update deployment doc #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update deployment doc #603

wants to merge 3 commits into from

Conversation

darshansreenivas
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darshansreenivas
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from carlory and pohly May 5, 2025 23:14
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @darshansreenivas. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2025
@darshansreenivas darshansreenivas mentioned this pull request May 5, 2025
Closed
@darshansreenivas darshansreenivas marked this pull request as ready for review May 5, 2025 23:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from humblec May 5, 2025 23:15
xing-yang
xing-yang reviewed May 6, 2025
View reviewed changes
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 20, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: darshansreenivas / name: Darshan Murthy (dba98d5, 88c0e5b)
  • ✅ login: Aishwarya-Hebbar (9205e32)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2025
xing-yang
xing-yang reviewed May 20, 2025
View reviewed changes
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2025
@xing-yang
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 28, 2025
Madhu-1
Madhu-1 suggested changes May 28, 2025
View reviewed changes
@darshansreenivas darshansreenivas requested a review from Madhu-1 May 28, 2025 16:41
Madhu-1
Madhu-1 reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, LGTM

@darshansreenivas
Copy link
Contributor Author

Thanks @xing-yang && @Madhu-1

@Madhu-1
Copy link
Contributor

Madhu-1 commented May 28, 2025

LGTM. @darshansreenivas can you please squash the commits

Aishwarya-Hebbar and others added 3 commits May 28, 2025 10:54
@Aishwarya-Hebbar @darshansreenivas
Squashed 'release-tools/' changes from 04965932..0a435bf9
9205e32 
0a435bf9 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34b Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e Bump golang to 1.24.0
f277d561 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a5 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
@darshansreenivas
spelling correction
dba98d5
@darshansreenivas
docs: improve deployment documentation for hostpath CSI driver
88c0e5b
@darshansreenivas darshansreenivas requested a review from Madhu-1 May 28, 2025 17:56
@Madhu-1
Copy link
Contributor

Madhu-1 commented May 30, 2025

/kind documentation
/lgtm
/assign @xing-yang

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@pohly pohly Awaiting requested review from pohly

@humblec humblec Awaiting requested review from humblec

@xing-yang xing-yang Awaiting requested review from xing-yang

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

Assignees

@xing-yang xing-yang

@Madhu-1 Madhu-1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darshansreenivas @k8s-ci-robot @xing-yang @Madhu-1 @carlory @Aishwarya-Hebbar