actionViewIntent to throw on unsupported file #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Android 9 I get an error "EUNSPECIFIED", and the file does not show up. Does anyone know why? |
|
@pavermakov did you encounter this error while testing this PR? Would anyone be able to test and/or confirm that throwing does not cause a crash? |
|
@Traviskn I've been using this PR in production for almost a year now and it just rejects the promise. Would be great if a someone else could verify though. |
cguino
added a commit
to BeApp/rn-fetch-blob
that referenced
this pull request
Jul 5, 2023
* blobmaster: (246 commits) version closes joltup#259 remove restrictions for legacy dir and android version fixes joltup#240 fixes joltup#255 adds missing import fixes joltup#258 fixes joltup#253 fixes joltup#251 adding new flag for downloadmanager to download to mediastore adds addeventlistener and removeeventlistener stumps to not get warnings android fs events missing json parse small fixes filesystem rework fetch part working for ios ios part version 2 Revert "ios part but no idea if working" some project changes ios part but no idea if working js side fix: fix bug Illegal callback invocation from native module Version ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a user tries to open an unsupported file,
actionViewIntentwill return a never-resolving promise. I propose to revert back to the functionality ofreact-native-fetch-blobwhere the promise rejects if the file is unsupported. This can be achieved either by removing the support-check (as I've done here) or at least make the promise reject if the support-check fails.