Skip to content

Add sub_path_expr to volume mount options #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jk-f5
Copy link

@jk-f5 jk-f5 commented Nov 16, 2024

Description

Added ability to declare sub_path_expr in volume mounts. I more or less just grepped for sub_path and added the equivalent code for sub_path_expr. I'm a bit shocked that this hasn't been added already.

Acceptance tests

  • Have you updated an existing acceptance tests for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS="-run '^TestAccKubernetes(Deployment|Pod|ReplicationController)'"
...
PASS

Release Note

Release note for CHANGELOG:

Enhancement
- Added ability to declare sub_path_expr in volume mounts. 

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@jk-f5 jk-f5 requested a review from a team as a code owner November 16, 2024 00:32
Copy link

hashicorp-cla-app bot commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from 40da2bc to 427d5ca Compare December 10, 2024 20:55
@jk-f5 jk-f5 requested a review from a team as a code owner December 10, 2024 20:55
@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from 427d5ca to cfeb53a Compare December 10, 2024 20:57
@github-actions github-actions bot added size/M and removed size/S labels Dec 10, 2024
@jk-f5
Copy link
Author

jk-f5 commented Dec 10, 2024

Can anyone tell me what I need to do to get this merged? I'd prefer not to have to continue using my own custom build of this provider if possible.

@jk-f5
Copy link
Author

jk-f5 commented Dec 18, 2024

Rebased on main

@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from d90f8f8 to 15982da Compare January 2, 2025 17:15
@jk-f5
Copy link
Author

jk-f5 commented Jan 2, 2025

Rebased on main

@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from 15982da to b013271 Compare February 28, 2025 16:58
@jk-f5
Copy link
Author

jk-f5 commented Feb 28, 2025

Rebased on main

Copy link

@s-annamalai-fetch s-annamalai-fetch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could get this merged

@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from b013271 to c5ab516 Compare April 2, 2025 15:44
@jk-f5
Copy link
Author

jk-f5 commented Apr 2, 2025

Rebased on main

@jk-f5 jk-f5 force-pushed the feat/sub_path_expr branch from c5ab516 to 01aa44b Compare May 19, 2025 22:38
@jk-f5
Copy link
Author

jk-f5 commented May 19, 2025

Rebased on main

@clark42
Copy link

clark42 commented Jun 3, 2025

Thanks @jk-f5 for your work and to keeping it update!
How we can help you to have an answer from hashicorp on this and get this merged?

@jk-f5
Copy link
Author

jk-f5 commented Jun 3, 2025

How we can help you to have an answer from hashicorp on this and get this merged?

I wish I knew. I'd be happy to make any changes necessary to get it merged.

@clark42
Copy link

clark42 commented Jun 3, 2025

Hello @alexsomesan, @jrhouston, and @arybolovlev,

Hope you’re all doing well this week.

Just wanted to check in regarding the PR that @jk-f5 opened a while back and has been keeping up to date.
I’m reaching out to make sure it’s still on your radar and hasn’t slipped through the cracks.
Some others issues related #920 #925

As someone who’s closely following this improvement to the Kubernetes provider, I’d really appreciate it if you could take a look when you get a chance.

Thanks a lot for your time and for everything you do on this project!

jrhouston
jrhouston previously approved these changes Jun 3, 2025
Copy link
Collaborator

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, branch needs to be rebased before I can merge it.

edit: Nevermind, conflict message went away once I approved workflows.

@jrhouston jrhouston force-pushed the feat/sub_path_expr branch from 98cc695 to ff5bc90 Compare June 3, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants