-
Notifications
You must be signed in to change notification settings - Fork 1k
Add sub_path_expr to volume mount options #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
40da2bc
to
427d5ca
Compare
427d5ca
to
cfeb53a
Compare
Can anyone tell me what I need to do to get this merged? I'd prefer not to have to continue using my own custom build of this provider if possible. |
cfeb53a
to
d90f8f8
Compare
Rebased on main |
d90f8f8
to
15982da
Compare
Rebased on main |
15982da
to
b013271
Compare
Rebased on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could get this merged
b013271
to
c5ab516
Compare
Rebased on main |
Rebased on main |
Thanks @jk-f5 for your work and to keeping it update! |
I wish I knew. I'd be happy to make any changes necessary to get it merged. |
Hello @alexsomesan, @jrhouston, and @arybolovlev, Hope you’re all doing well this week. Just wanted to check in regarding the PR that @jk-f5 opened a while back and has been keeping up to date. As someone who’s closely following this improvement to the Kubernetes provider, I’d really appreciate it if you could take a look when you get a chance. Thanks a lot for your time and for everything you do on this project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, branch needs to be rebased before I can merge it.
edit: Nevermind, conflict message went away once I approved workflows.
98cc695
to
ff5bc90
Compare
Description
Added ability to declare sub_path_expr in volume mounts. I more or less just grepped for sub_path and added the equivalent code for sub_path_expr. I'm a bit shocked that this hasn't been added already.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note