Keeping consistent between UI and API about combined commit status state and fix some bugs #34562
+482
−281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from #34531
Move Commit status state to a standalone package
Move the state from
structs
tocommitstatus
package. It also introduceCommitStatusStates
so that the combine function could be used from UI and API logic.Combined commit status Changed
This PR will follow Github's combined commit status. Before this PR, every commit status could be a combined one.
According to https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#get-the-combined-status-for-a-specific-reference
This PR will follow that rule and remove the
NoBetterThan
logic. This also fixes the inconsistent between UI and API. In the API convert package, it has implemented this which is different from the UI. It also fixed the missingURL
andCommitURL
in the API.CalcCommitStatus
return nil if there is no commit statusesThe behavior of
CalcCommitStatus
is changed. If the parameter commit statuses is empty, it will return nil. The reference places should check the returned value themselves.