Skip to content

Hide href attribute of a tag if there is no target_url #34556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Hide href attribute of a tag if there is no target_url #34556

merged 2 commits into from
Jun 10, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented May 28, 2025

Relate #34450

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2025
@yp05327 yp05327 added this to the 1.25.0 milestone Jun 10, 2025
@yp05327 yp05327 added the backport/v1.24 This PR should be backported to Gitea 1.24 label Jun 10, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 10, 2025
@lunny lunny enabled auto-merge (squash) June 10, 2025 19:30
@lunny lunny merged commit 17cfae8 into go-gitea:main Jun 10, 2025
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 10, 2025
@lunny @GiteaBot
Hide href attribute of a tag if there is no target_url (go-gitea#34556)
c57bb5d 
Relate go-gitea#34450
@GiteaBot GiteaBot mentioned this pull request Jun 10, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 10, 2025
@lunny lunny deleted the lunny/hide_href_if_empty branch June 10, 2025 19:33
lunny added a commit that referenced this pull request Jun 11, 2025
@GiteaBot @lunny
Hide href attribute of a tag if there is no target_url (#34556) (#34684)
64b9b21 
Backport #34556 by @lunny

Relate #34450

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 11, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
17d7023 
* giteaofficial/main:
  Fix pull requests API convert panic when head repository is deleted. (go-gitea#34685)
  [skip ci] Updated translations via Crowdin
  Hide href attribute of a tag if there is no target_url (go-gitea#34556)
  Fix commit message rendering and some UI problems (go-gitea#34680)
  Migrate to urfave v3 (go-gitea#34510)
Chi-Iroh pushed a commit to Chi-Iroh/gitea that referenced this pull request Jun 11, 2025
@lunny
Hide href attribute of a tag if there is no target_url (go-gitea#34556)
3ec59c3 
Relate go-gitea#34450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @yp05327 @hiifong @GiteaBot