-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Run integration tests against postgres 14 #34514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres.
.github/workflows/pull-db-tests.yml
Outdated
@@ -17,7 +17,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
services: | |||
pgsql: | |||
image: postgres:12 | |||
image: postgres:16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not 17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would run both oldest and newest (13 and 17), but so far there is only one DB version, and 16 is a seemingly good "in between". But if people want 17, we can do 17 of course.
May 13 is better which is the minimal requirement. And we should also update the documentation about database requirements. |
I'd go straight to 14 for v1.25 given the EOL date of 13. |
I'd just change docs to require any maintained postgres version, so you don't need to babysit a minimum version in the docs each year. |
Changed it to 14 now. The discussion whether to use latest is not one I want to have right now. |
postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on.
Ref: https://endoflife.date/postgresql