Skip to content

Run integration tests against postgres 14 #34514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 21, 2025

postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on.

Ref: https://endoflife.date/postgresql

postgres 12 is end of life since 6 months. 13 and above are still
supported but I think it's overall better if we test a more recent
version of postgres.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2025
@@ -17,7 +17,7 @@ jobs:
runs-on: ubuntu-latest
services:
pgsql:
image: postgres:12
image: postgres:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 17?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would run both oldest and newest (13 and 17), but so far there is only one DB version, and 16 is a seemingly good "in between". But if people want 17, we can do 17 of course.

@lunny
Copy link
Member

lunny commented May 21, 2025

May 13 is better which is the minimal requirement. And we should also update the documentation about database requirements.

@silverwind
Copy link
Member Author

May 13 is better which is the minimal requirement. And we should also update the documentation about database requirements.

I'd go straight to 14 for v1.25 given the EOL date of 13.

@silverwind
Copy link
Member Author

And we should also update the documentation about database requirements.

I'd just change docs to require any maintained postgres version, so you don't need to babysit a minimum version in the docs each year.

@silverwind
Copy link
Member Author

Changed it to 14 now. The discussion whether to use latest is not one I want to have right now.

@silverwind silverwind changed the title Run integration tests against postgres 16 Run integration tests against postgres 14 May 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2025
@lunny lunny added this to the 1.25.0 milestone May 22, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) May 23, 2025 04:14
@techknowlogick techknowlogick added backport/v1.24 This PR should be backported to Gitea 1.24 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 23, 2025
@techknowlogick techknowlogick merged commit 8365365 into go-gitea:main May 23, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants