-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
WIP Implementation of required workflows Actions #31869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c0d50fd
to
3b8177f
Compare
It's too flexible to allow the workflows from any repositories. How about only allow workflows from a special repository like |
Sure, @lunny thanks for reviewing, let me put that filter logic in. I was trying to implement the basic minimal feature and discuss the implementation details with the actions maintainer so any suggestion is welcome. |
Maybe keeping them in the same PR is better? So later reviewers can have context in the same place? |
Typo in title? RequestActions? RequireActions? |
…ove WIP Signed-off-by: Alex Lau(AvengerMoJo) <avengermojo@gmail.com>
d277830
to
abac1ea
Compare
abac1ea
to
f80737d
Compare
@lunny adding a filter to make sure only .workflow repo could add as Global Required Workflow actions |
f80737d
to
c7e9f29
Compare
Signed-off-by: Alex Lau(AvengerMoJo) <avengermojo@gmail.com>
c7e9f29
to
eaa173a
Compare
@yp05327 fixed, along with the filter for .workflow repo only to enable global required workflow. |
@lunny any suggestion for my next step to include this in the next feature update? |
It is a large PR, would like to add this updated PR to replace #30067 and start creating test cases for it.