Skip to content

Use actions/cache for go lint actions #31266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Use actions/cache for go lint actions #31266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6135b90
Use cache for go lint actions
silverwind Jun 5, 2024
be14784
stop using golangci-lint-action
silverwind Jun 5, 2024
7968022
fix keys
silverwind Jun 5, 2024
d7cc20d
really fix key
silverwind Jun 5, 2024
fa2d25d
also add go-build cache
silverwind Jun 5, 2024
d2363f9
add more dependency files to cache key
silverwind Jun 5, 2024
7138cc5
add reusable workflows, cache GOMODCACHE as well
silverwind Jun 5, 2024
bb145f7
fix lint
silverwind Jun 5, 2024
09ebbde
fix lint
silverwind Jun 5, 2024
48e04a6
un-reuse
silverwind Jun 5, 2024
8e72066
lint
silverwind Jun 5, 2024
fcb852f
remove GOMODCACHE
silverwind Jun 5, 2024
7c66eb9
cleanup
silverwind Jun 5, 2024
3120719
don't pre-install deps-tools in checks-backend
silverwind Jun 6, 2024
35da678
Revert "don't pre-install deps-tools in checks-backend"
silverwind Jun 6, 2024
df5f625
Merge branch 'main' into cache
silverwind Jun 6, 2024
3148022
Merge branch 'main' into cache
silverwind Jun 6, 2024
2dddb9d
Merge branch 'main' into cache
techknowlogick Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/pull-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,28 @@ jobs:
with:
go-version-file: go.mod
check-latest: true
- id: vars
run: |
echo "GOCACHE=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
echo "GOVERSION=$(go env GOVERSION)" >> "$GITHUB_OUTPUT"
- uses: actions/cache/restore@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}
- run: make deps-backend deps-tools
- run: make lint-backend
env:
TAGS: bindata sqlite sqlite_unlock_notify
- uses: actions/cache/save@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}

lint-templates:
if: needs.files-changed.outputs.templates == 'true'
Expand Down Expand Up @@ -94,12 +112,30 @@ jobs:
with:
go-version-file: go.mod
check-latest: true
- id: vars
run: |
echo "GOCACHE=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
echo "GOVERSION=$(go env GOVERSION)" >> "$GITHUB_OUTPUT"
- uses: actions/cache/restore@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}
- run: make deps-backend deps-tools
- run: make lint-go-windows lint-go-vet
env:
TAGS: bindata sqlite sqlite_unlock_notify
GOOS: windows
GOARCH: amd64
- uses: actions/cache/save@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}

lint-go-gogit:
if: needs.files-changed.outputs.backend == 'true' || needs.files-changed.outputs.actions == 'true'
Expand All @@ -111,10 +147,28 @@ jobs:
with:
go-version-file: go.mod
check-latest: true
- id: vars
run: |
echo "GOCACHE=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
echo "GOVERSION=$(go env GOVERSION)" >> "$GITHUB_OUTPUT"
- uses: actions/cache/restore@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}
- run: make deps-backend deps-tools
- run: make lint-go
env:
TAGS: bindata gogit sqlite sqlite_unlock_notify
- uses: actions/cache/save@v4
with:
path: |
~/.cache/golangci-lint
~/.cache/gopls
${{ steps.vars.outputs.GOCACHE }}
key: golint-v1-${{ github.job }}-${{ runner.os }}-${{ runner.arch }}-${{ steps.vars.outputs.GOVERSION }}-${{ hashFiles('go.mod', 'Makefile', '.golangci.yml', 'tools/lint-go-gopls.sh') }}

checks-backend:
if: needs.files-changed.outputs.backend == 'true' || needs.files-changed.outputs.actions == 'true'
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ lint-editorconfig:

.PHONY: lint-actions
lint-actions:
$(GO) run $(ACTIONLINT_PACKAGE)
SHELLCHECK_OPTS='-e SC2129' $(GO) run $(ACTIONLINT_PACKAGE)

.PHONY: lint-templates
lint-templates: .venv node_modules
Expand Down