Skip to content

Organization Members Page add "Invite Member" button #27800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Organization Members Page add "Invite Member" button #27800

wants to merge 14 commits into from

Conversation

Sonic853
Copy link
Contributor

close #22054

Snipaste_2023-10-26_20-28-05

Snipaste_2023-10-26_20-27-00

Snipaste_2023-10-26_20-27-32

Snipaste_2023-10-26_20-42-23

Snipaste_2023-10-26_20-42-05

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 26, 2023
@lunny
Copy link
Member

lunny commented Oct 27, 2023

The UI needs some tweak

wxiaoguang
wxiaoguang reviewed Oct 27, 2023
View reviewed changes
@Sonic853
Copy link
Contributor Author

The UI needs some tweak

Have more detailed UI suggestions?

@silverwind
Copy link
Member

silverwind commented Oct 27, 2023 •
edited
Loading

The UI needs some tweak

Have more detailed UI suggestions?

I would render the "Invite" and other text like body text, not like a button as you have. Maybe also layout across multiple lines so it's more mobile-friendly.

@Sonic853
Copy link
Contributor Author

The UI needs some tweak

Have more detailed UI suggestions?

I would render the "Invite" and other text like body text, not like a button as you have. Maybe also layout across multiple lines so it's more mobile-friendly.

I modified it
image

As well as adding a new backend handler as suggested by @wxiaoguang

gitea/routers/web/web.go

Line 800 in cdfa2dd

m.Post("/members/invite", org.MembersInviteAction)

wxiaoguang
wxiaoguang reviewed Oct 30, 2023
View reviewed changes
@silverwind silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Nov 2, 2023
@yp05327
Copy link
Contributor

yp05327 commented Nov 7, 2023 •
edited
Loading

A modal meets the need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/translation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organization Members Page add "Invite Member" button
7 participants
@Sonic853 @lunny @silverwind @yp05327 @wxiaoguang @techknowlogick @GiteaBot