-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add FormBuilderCupertinoDateTimePicker
#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add FormBuilderCupertinoDateTimePicker
#23
Conversation
734863f
to
ad52fd9
Compare
3113e83
to
17d27dd
Compare
17d27dd
to
367ccaa
Compare
@deandreamatias any plans to merge this? Would be ideal to depend on a published version instead of my fork.. |
@charlieforward9 really sorry, I didn't seen this before. I need to activate notification for new PR on this repo. Please take a look on conflicts. When resolve, I will run de the pipeline and merge if is all ok |
@deandreamatias done |
@deandreamatias I am not sure what else needs to be done here but I just had to bump |
Looks like some formatting issue was thrown in the action and then something related to I can attempt to contribute to this fix soon if you'd like, but I'm looking for some improved communication. |
I need find a solution to build with stable and beta flutter versions on parallel branches, because the current pipeline implementation has the issue that can't use different intl versions. |
I'm working on solution for flutter versions. See flutter-form-builder-ecosystem/flutter_form_builder#1486 |
@charlieforward9 please update your branch with the new code on main. Thanks! |
Connection with issue(s)
Close #3
Solution description
Pulled the source code from https://github.com/flutter-form-builder-ecosystem/flutter_form_builder/blob/main/lib/src/fields/form_builder_date_time_picker.dart and converted all the
material
dependencies tocupertino
. Removed undefined fields and had to pull a few of the types/enums/defs into the repo to avoid material dependency. The only exception to this is theTimeOfDay
class, which has had some unfavorable discussions about making it agnostic.Screenshots or Videos
To Do