Skip to content

feat: add FormBuilderCupertinoDateTimePicker #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

charlieforward9
Copy link

@charlieforward9 charlieforward9 commented Feb 20, 2025

Connection with issue(s)

Close #3

Solution description

Pulled the source code from https://github.com/flutter-form-builder-ecosystem/flutter_form_builder/blob/main/lib/src/fields/form_builder_date_time_picker.dart and converted all the material dependencies to cupertino. Removed undefined fields and had to pull a few of the types/enums/defs into the repo to avoid material dependency. The only exception to this is the TimeOfDay class, which has had some unfavorable discussions about making it agnostic.

Screenshots or Videos

Date Time
Date Time

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@charlieforward9 charlieforward9 marked this pull request as ready for review February 20, 2025 05:45
@charlieforward9 charlieforward9 force-pushed the main branch 4 times, most recently from 3113e83 to 17d27dd Compare February 20, 2025 08:12
@charlieforward9
Copy link
Author

@deandreamatias any plans to merge this? Would be ideal to depend on a published version instead of my fork..

@deandreamatias
Copy link
Contributor

@charlieforward9 really sorry, I didn't seen this before. I need to activate notification for new PR on this repo.

Please take a look on conflicts. When resolve, I will run de the pipeline and merge if is all ok

@charlieforward9
Copy link
Author

@deandreamatias done

@charlieforward9
Copy link
Author

@deandreamatias I am not sure what else needs to be done here but I just had to bump intl on my fork and include that in here as well so it would be really nice to see this merged in so I can depend on the official package. Thank you.

@charlieforward9
Copy link
Author

charlieforward9 commented Apr 11, 2025

Looks like some formatting issue was thrown in the action and then something related to errorBuilder overriding an updated Flutter FormField API. Not sure if this is on all channels. I am on Flutter master channel.

I can attempt to contribute to this fix soon if you'd like, but I'm looking for some improved communication.

@deandreamatias
Copy link
Contributor

I need find a solution to build with stable and beta flutter versions on parallel branches, because the current pipeline implementation has the issue that can't use different intl versions.
Give me some days and I will find how solve this.

@deandreamatias
Copy link
Contributor

I'm working on solution for flutter versions. See flutter-form-builder-ecosystem/flutter_form_builder#1486
After validate there, I will copy on this repo

@deandreamatias
Copy link
Contributor

@charlieforward9 please update your branch with the new code on main. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FormBuilderCupertinoDateTimePicker
2 participants