Close webchannel instances on terminate #9041

MarkDuckworth · 2025-05-14T19:15:35Z

CI logs showed that some WebChannel connections were being left open after tests. This change implements the terminate() method on the WebChannelConnection class to ensure that any open WebChannelConnections are closed when the SDK terminates.

changeset-bot · 2025-05-14T19:15:39Z

🦋 Changeset detected

Latest commit: 8bd74f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-05-14T19:15:49Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

google-oss-bot · 2025-05-14T19:25:16Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (799de59) Merge (80b2770) Diff
browser 385 kB 385 kB +151 B (+0.0%)
module 385 kB 385 kB +151 B (+0.0%)
react-native 385 kB 386 kB +151 B (+0.0%)

`bundle`

Type	Base (`799de59`)	Merge (`80b2770`)	Diff
firestore (CSI Auto Indexing Disable and Delete)	280 kB	280 kB	+151 B (+0.1%)
firestore (CSI Auto Indexing Enable)	280 kB	280 kB	+151 B (+0.1%)
firestore (Persistence)	311 kB	311 kB	+151 B (+0.0%)
firestore (Query Cursors)	256 kB	256 kB	+151 B (+0.1%)
firestore (Query)	254 kB	254 kB	+151 B (+0.1%)
firestore (Read data once)	242 kB	242 kB	+151 B (+0.1%)
firestore (Read Write w Persistence)	335 kB	336 kB	+151 B (+0.0%)
firestore (Realtime updates)	244 kB	244 kB	+151 B (+0.1%)
firestore (Transaction)	221 kB	221 kB	+151 B (+0.1%)
firestore (Write data)	220 kB	220 kB	+151 B (+0.1%)

firebase
Type Base (799de59) Merge (80b2770) Diff
firebase-compat.js 802 kB 802 kB +149 B (+0.0%)
firebase-firestore-compat.js 347 kB 347 kB +149 B (+0.0%)
firebase-firestore.js 449 kB 449 kB +151 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/kAOEozX8W6.html

google-oss-bot · 2025-05-14T19:36:52Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- addDoc
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 135 kB 135 kB +151 B (+0.1%)
  size-with-ext-deps 211 kB 211 kB +151 B (+0.1%)
- deleteDoc
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 125 kB 125 kB +151 B (+0.1%)
  size-with-ext-deps 201 kB 201 kB +151 B (+0.1%)
- disableNetwork
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 113 kB 113 kB +151 B (+0.1%)
  size-with-ext-deps 190 kB 190 kB +151 B (+0.1%)
- enableIndexedDbPersistence
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 189 kB 189 kB +151 B (+0.1%)
  size-with-ext-deps 266 kB 266 kB +151 B (+0.1%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 226 kB 226 kB +151 B (+0.1%)
  size-with-ext-deps 302 kB 302 kB +151 B (+0.0%)
- enableNetwork
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 113 kB 113 kB +151 B (+0.1%)
  size-with-ext-deps 190 kB 190 kB +151 B (+0.1%)
- executeWrite
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 124 kB 124 kB +151 B (+0.1%)
  size-with-ext-deps 200 kB 200 kB +151 B (+0.1%)
- getAggregateFromServer
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 121 kB 121 kB +151 B (+0.1%)
  size-with-ext-deps 197 kB 197 kB +151 B (+0.1%)
- getCountFromServer
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 121 kB 121 kB +151 B (+0.1%)
  size-with-ext-deps 197 kB 198 kB +151 B (+0.1%)
- getDoc
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 156 kB 156 kB +151 B (+0.1%)
  size-with-ext-deps 232 kB 232 kB +151 B (+0.1%)
- getDocFromServer
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 156 kB 156 kB +151 B (+0.1%)
  size-with-ext-deps 232 kB 232 kB +151 B (+0.1%)
- getDocs
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 157 kB 157 kB +151 B (+0.1%)
  size-with-ext-deps 234 kB 234 kB +151 B (+0.1%)
- getDocsFromServer
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 157 kB 157 kB +151 B (+0.1%)
  size-with-ext-deps 233 kB 234 kB +151 B (+0.1%)
- loadBundle
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 123 kB 123 kB +151 B (+0.1%)
  size-with-ext-deps 199 kB 199 kB +151 B (+0.1%)
- memoryLocalCache
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 107 kB 108 kB +151 B (+0.1%)
  size-with-ext-deps 184 kB 184 kB +151 B (+0.1%)
- onSnapshot
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 158 kB 158 kB +151 B (+0.1%)
  size-with-ext-deps 234 kB 234 kB +151 B (+0.1%)
- onSnapshotsInSync
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 147 kB 147 kB +151 B (+0.1%)
  size-with-ext-deps 223 kB 223 kB +151 B (+0.1%)
- persistentLocalCache
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 185 kB 185 kB +151 B (+0.1%)
  size-with-ext-deps 262 kB 262 kB +151 B (+0.1%)
- persistentMultipleTabManager
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 221 kB 221 kB +151 B (+0.1%)
  size-with-ext-deps 298 kB 298 kB +151 B (+0.1%)
- persistentSingleTabManager
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 185 kB 185 kB +151 B (+0.1%)
  size-with-ext-deps 261 kB 262 kB +151 B (+0.1%)
- runTransaction
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 135 kB 135 kB +151 B (+0.1%)
  size-with-ext-deps 211 kB 211 kB +151 B (+0.1%)
- setDoc
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 134 kB 134 kB +151 B (+0.1%)
  size-with-ext-deps 210 kB 210 kB +151 B (+0.1%)
- updateDoc
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 134 kB 134 kB +151 B (+0.1%)
  size-with-ext-deps 211 kB 211 kB +151 B (+0.1%)
- waitForPendingWrites
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 114 kB 114 kB +151 B (+0.1%)
  size-with-ext-deps 190 kB 190 kB +151 B (+0.1%)
- writeBatch
  Size
  Type Base (799de59) Merge (80b2770) Diff
  size 136 kB 136 kB +151 B (+0.1%)
  size-with-ext-deps 212 kB 213 kB +151 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ihyv5uyD8p.html

MarkDuckworth added 2 commits May 14, 2025 13:04

Explicitly close any unclosed WebChannel instances on terminate

2211693

Comments and naming

6466b3f

dconeybe approved these changes May 14, 2025

View reviewed changes

Create spotty-ghosts-kneel.md

d5693c1

MarkDuckworth marked this pull request as ready for review May 14, 2025 20:38

MarkDuckworth requested review from a team as code owners May 14, 2025 20:38

Update webchannel_connection.ts

8bd74f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Close webchannel instances on terminate #9041

Close webchannel instances on terminate #9041

MarkDuckworth commented May 14, 2025 •

edited

Loading

changeset-bot bot commented May 14, 2025 •

edited

Loading

github-actions bot commented May 14, 2025

google-oss-bot commented May 14, 2025 •

edited

Loading

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented May 14, 2025 •

edited

Loading

`@firebase/firestore`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`loadBundle`

`memoryLocalCache`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`updateDoc`

`waitForPendingWrites`

`writeBatch`

Close webchannel instances on terminate #9041

Are you sure you want to change the base?

Close webchannel instances on terminate #9041

Conversation

MarkDuckworth commented May 14, 2025 • edited Loading

changeset-bot bot commented May 14, 2025 • edited Loading

🦋 Changeset detected

github-actions bot commented May 14, 2025

Vertex AI Mock Responses Check ⚠️

google-oss-bot commented May 14, 2025 • edited Loading

Size Report 1

Affected Products

@firebase/firestore

bundle

firebase

Test Logs

google-oss-bot commented May 14, 2025 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/firestore

addDoc

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromServer

getDocs

getDocsFromServer

loadBundle

memoryLocalCache

onSnapshot

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

updateDoc

waitForPendingWrites

writeBatch

Test Logs

MarkDuckworth commented May 14, 2025 •

edited

Loading

changeset-bot bot commented May 14, 2025 •

edited

Loading

google-oss-bot commented May 14, 2025 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`bundle`

`firebase`

google-oss-bot commented May 14, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`loadBundle`

`memoryLocalCache`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`updateDoc`

`waitForPendingWrites`

`writeBatch`