Skip to content

trie: upgrade hashFullNodeChildren #31851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

trie: upgrade hashFullNodeChildren #31851

wants to merge 1 commit into from
+10 −10

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented May 18, 2025 •
edited
Loading

Just create hasher and goroutine for child != nil condition.

@mask-pp mask-pp requested a review from rjl493456442 as a code owner May 18, 2025 16:02
@rjl493456442
Copy link
Member

Have you measured the impact of this change on memory allocations?

@mask-pp
Copy link
Contributor Author

mask-pp commented May 19, 2025 •
edited
Loading

Have you measured the impact of this change on memory allocations?

Oh, this PR cannot solve the memory allocation problem. This change is almost meaningless

@mask-pp mask-pp marked this pull request as draft May 19, 2025 06:13
@mask-pp mask-pp closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mask-pp @rjl493456442