Skip to content

test: to avoid lag between tx inclusion and accessible state over RPC #31849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

test: to avoid lag between tx inclusion and accessible state over RPC #31849

wants to merge 5 commits into from
+311 −0

Conversation

mmsqe
Copy link

@mmsqe mmsqe commented May 18, 2025

for more info, #31798

jwasinger
jwasinger reviewed May 20, 2025
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that this test would not reliably trigger if the underlying issue was not fixed? It would fail sometimes, but not most of the time. If so, I don't think it's worth including.

@mmsqe
Copy link
Author

mmsqe commented May 20, 2025

My understanding is that this test would not reliably trigger if the underlying issue was not fixed? It would fail sometimes, but not most of the time. If so, I don't think it's worth including.

Got it thanks, since it's easy to get UnexpectedCodeError when use pebble.Sync in mac, but not in windows.

@mmsqe mmsqe closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger jwasinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @jwasinger