core/blockchain: remove unnecessary fmt.Sprintf in log.Error calls #31842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
previously approved these changes
May 20, 2025
| @@ -652,8 +652,8 @@ func (bc *BlockChain) initializeHistoryPruning(latest uint64) error { | |||
| // postmerge directly on an existing DB. We could just trigger the pruning | |||
| // here, but it'd be a bit dangerous since they may not have intended this | |||
| // action to happen. So just tell them how to do it. | |||
| log.Error(fmt.Sprintf("Chain history mode is configured as %q, but database is not pruned.", bc.cacheConfig.ChainHistoryMode.String())) | |||
| log.Error(fmt.Sprintf("Run 'geth prune-history' to prune pre-merge history.")) | |||
| log.Error("Chain history mode is configured as %q, but database is not pruned.", bc.cacheConfig.ChainHistoryMode.String()) | |||
There was a problem hiding this comment.
This doesn't work, log.Error does not work the same as fmt.Sprintf
|
Yeah I don't think it makes much sense to do this. Its not really important to change this |
Ok boss, thanks for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced redundant usage of fmt.Sprintf inside log.Error calls with direct formatting arguments.
This change improves code clarity and performance.
No functional changes were made.