Add Table structure evaluations for TEDS #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenmidde
force-pushed
the
p_addStructOnlyResultsIntoEvaluations
branch
from
e106bbe to
bf29960
Compare
praveenmidde
force-pushed
the
p_addStructOnlyResultsIntoEvaluations
branch
from
c6ec8a9 to
e3997a8
Compare
Signed-off-by: Praveen Kumar Midde <praveen.midde@gmail.com>
Signed-off-by: Praveen Kumar Midde <praveen.midde@gmail.com>
…tion Signed-off-by: Praveen Kumar Midde <praveen.midde@gmail.com>
praveenmidde
force-pushed
the
p_addStructOnlyResultsIntoEvaluations
branch
from
22c545d to
1d4579a
Compare
PeterStaar-IBM
requested changes
May 24, 2025
| @@ -42,6 +43,7 @@ class TableEvaluation(UnitEvaluation): | |||
|
|
|||
| class DatasetTableEvaluation(DatasetEvaluation): | |||
| evaluations: List[TableEvaluation] | |||
| structure_only_evaluations: Optional[List[TableEvaluation]] = None | |||
There was a problem hiding this comment.
Let's call the variable table_structure_evaluations and do not make it optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the "evaluations" hold independent results of tables for TEDS only. Extend it to include the values of TEDS_struct evaluations as well.