Fix issue with layout text not correctly populated, add tests #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samved Divekar <scdiveka@us.ibm.com>
added 4 commits
May 20, 2025 08:57
Signed-off-by: Samved Divekar <scdiveka@us.ibm.com>
Signed-off-by: Samved Divekar <scdiveka@us.ibm.com>
Signed-off-by: Samved Divekar <scdiveka@us.ibm.com> Signed-off-by: Samved Divekar <scdiveka@us.ibm.com>
added 2 commits
May 27, 2025 00:03
Signed-off-by: Samved Divekar <scdiveka@us.ibm.com> Signed-off-by: Samved Divekar <scdiveka@us.ibm.com>
cau-git
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @cau-git 's hint about text fields not getting populated, we traced back the root cause. The "Text" field in Layout blocks is optional. It's only mandatory for "LINE" type, for all others it is to be accessed through children refs. Hence the update.
We were able to get back the eval numbers we were generating before we introduced layout changes. (Tested with FInTabNet and Pub1M samples of 15 docs each.)
Open Issues:
DPBench and OmniDocBench still don't work and return -1 in the results. (It finishes without an error)After specifying a range for DPBench docs, issue couldn't be re-produced.