feat: Table Enrichment - Descriptions and Indexing #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Signed-off-by: Nikhil Khandelwal <nikhil.khandelwal3@ibm.com>
Nikhil200030
force-pushed
the
table-enrichment
branch
from
9b89920 to
194d8ff
Compare
dolfim-ibm
requested changes
May 14, 2025
| @@ -282,9 +329,24 @@ def _serialize_image_part( | |||
| text_res = image_placeholder | |||
| else: | |||
| text_res = f"})" | |||
|
|
|||
| elif image_mode == ImageRefMode.DESCRIPTION: | |||
There was a problem hiding this comment.
ImageRefMode is not supposed to be used for switching to the description output.
We recently introduced the concept of Serializers exactly for this purpose.
See docs at: https://docling-project.github.io/docling/concepts/serialization/
Examples at: https://docling-project.github.io/docling/examples/serialization/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented code to retrieve table descriptions using LLMs and insert them back into the markdown file at the appropriate indices.