Add support for devices with a notch and corresponding tests #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `allDevicesWithNotch` static property to list devices with a notch. - Implement `hasNotch` instance property to check if a device has a notch. - Add `testHasNotch` method in `DeviceKitTests` to verify the `hasNotch` functionality.
|
Hi @Zandor300, I have added support for testing devices with notch. Best regards. |
Zandor300
requested changes
May 25, 2025
- Add hasNotch property to Device class - Update Device class constructor to include hasNotch parameter - Modify allDevicesWithNotch and hasNotch methods to use updated logic - Adjust indentation and formatting in various sections of the code for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allDevicesWithNotchstatic property to list devices with a notch.hasNotchinstance property to check if a device has a notch.testHasNotchmethod inDeviceKitTeststo verify thehasNotchfunctionality.