-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
make Pulse installation non-interactive #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
make Pulse installation non-interactive #4848
Conversation
a160c29
to
05a4c7f
Compare
- Remove all interactive prompts during installation - Remove .env setup (handled by web UI) - Remove configuration messages (handled by web UI) - Change install directory from /opt/pulse-proxmox to /opt/pulse - Update JSON note to reflect web-based setup wizard Pulse now features a complete web-based configuration system with automatic setup detection, making manual .env configuration obsolete. The new workflow: 1. Script installs Pulse without any user interaction 2. Service starts automatically 3. User navigates to the provided URL 4. Pulse shows setup wizard for configuration 5. No SSH or manual file editing required This provides the ideal community script experience - completely hands-off installation with configuration through the web interface. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
05a4c7f
to
f8f7466
Compare
I mark this as Breaking change, because Paths Changes and i think an new build (create new LXC) is better By the way, do you need to edit the pulse.sh too? Because Paths |
- Change paths from /opt/pulse-proxmox to /opt/pulse - Remove .env file backup/restore logic since Pulse now uses web-based configuration - Simplify permissions setting to match new installation approach 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Good catch! I've updated Regarding the path change - you're right it's technically breaking, but it also resolves a potential copyright concern with using 'pulse-proxmox' in the directory name. The new |
@rcourtman Existing users are definitely impacted, if an existing user will upgrade using the update function, I'll will fail, no? maybe you could do the following:
|
555 installs of Pulse
|
Thanks for the feedback. I apologize for the path change - I understand it may seem unnecessary given the issues it causes, but unfortunately I'm already quite far along this path in my development. This should be the last time the path needs to change. I've enhanced the migration logic in the Pulse project's installer script ( When users with existing
This minimizes disruption to existing installations while maintaining the cleaner path structure. Users would need to run the installer again and the migration happens automatically. Would this address your concerns about breaking existing installations? |
I can go back to the old path if needed. @MickLesk since you mentioned you use Pulse, perhaps you could try the migration in my install script? If it works, you'll have peace of mind that existing users have an easy path to switch. If it doesn't, we can stick to the old path and I'll make adjustments on my end. |
I think we should use the new path, only an Check If old directory "please recreate the LXC after Breaking Change (Link to PR) |
Description
Streamline Pulse installation to leverage its new web-based configuration system, removing all interactive prompts and manual configuration steps.
Related PR/Issue: #4827 (previous discussion about making Pulse non-interactive)
Prerequisites
Type of Change
Changes Made
/opt/pulse-proxmox
to/opt/pulse
for cleaner pathsContext
Pulse v3.13.0+ features a complete web-based configuration system with automatic setup detection. When users navigate to the URL after installation, Pulse automatically shows a setup wizard for entering Proxmox credentials. No SSH or manual file editing required.
This provides the ideal community script experience - completely hands-off installation with all configuration handled through the modern web interface.