Skip to content

Fix: Move <h2> outside of <ul> for improved semantic structure #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions 3-box-model/16-spaced-out/index.html
Original file line number Diff line number Diff line change
@@ -1,20 +1,32 @@
<!-- Spaced Out 🛰️ -->
<!-- Codédex -->

<div id="outside-wrapper" style="width:80%;">
<img id="top-img" src="https://images.unsplash.com/photo-1551027654-f7b9f56804c7?ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D&auto=format&fit=crop&w=687&q=80" style="width:10em; height:10em;" />
<div id="outside-wrapper" style="width: 80%">
<img
id="top-img"
src="https://images.unsplash.com/photo-1551027654-f7b9f56804c7?ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D&auto=format&fit=crop&w=687&q=80"
style="width: 10em; height: 10em"
/>

<h2>My Feed</h2>
<ul id="post-list">
<h2>My Feed</h2>
<li>
<div class="post-wrapper">
<img class="post-img" src="https://www.carnegielibrary.org/wp-content/uploads/2016/02/CLPMain_1080x600.jpg" alt="Carnegie Library of Pittsburgh" style="width:100%;" />
<p>Visited the library! 📚 <b>#libraries</b> <b>#readingisawesome</b></p>
<img
class="post-img"
src="https://www.carnegielibrary.org/wp-content/uploads/2016/02/CLPMain_1080x600.jpg"
alt="Carnegie Library of Pittsburgh"
style="width: 100%"
/>
<p>
Visited the library! 📚 <b>#libraries</b> <b>#readingisawesome</b>
</p>
</div>
</li>
<li>
<div class="post-wrapper">
<img class="post-img" src="https://media.giphy.com/media/AFHFoEv9fDOn7lIdlD/giphy.gif" alt="GIF of two people fist-bumping with the caption 'YOU GOT THIS'" style="width:100%;" />
<img class="post-img" src="https://media.giphy.com/media/AFHFoEv9fDOn7lIdlD/giphy.gif" alt="GIF of two people fist-bumping with the caption 'YOU GOT THIS'" style="width:100%;" />

<p>Carpe diem! <b>#wordsofencouragement</b> <b>#wordsofwisdom</b></p>
</div>
</li>
Expand Down