Skip to content

feat: Added possibility to enable replica tags propagation #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

szheliab
Copy link

what

This minor change is for adding possibility to propagate tags to the Global Table replicas using variable propagate_tags_to_replica

why

It can be useful for users that need to have tags applied across all AWS resources.

references

closes #119

@szheliab szheliab requested review from a team as code owners November 12, 2024 16:09
@mergify mergify bot added the triage Needs triage label Nov 12, 2024
@szheliab
Copy link
Author

Hi
Could someone take a look at this PR?
Thanks

@RoseSecurity
Copy link

/terratest

@RoseSecurity RoseSecurity added enhancement New feature or request minor New features that do not break anything labels Apr 23, 2025
@RoseSecurity
Copy link

Thank you for this contribution. The tests are failing for an unrelated reason, so I am actively working to fix these so that we can get this change incorporated

Copy link

mergify bot commented May 29, 2025

💥 This pull request now has conflicts. Could you fix it @szheliab? 🙏

@mergify mergify bot added the conflict This PR has conflicts label May 29, 2025
Copy link

mergify bot commented May 29, 2025

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot closed this May 29, 2025
@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replicas do not have default_tags applied to them
2 participants