Skip to content

Introducing 'preview_enabled' on the next_entity_type_config entity #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bojanbogdanovic
Copy link
Contributor

@bojanbogdanovic bojanbogdanovic commented Jan 18, 2024

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • Other

GitHub Issue: #496

Describe your changes

I have decoupled the site resolver from preview mode in the 'next_entity_type_config' and added a new 'preview_enabled' property. This property gives the ability to enable/disable the preview mode on specific entities. The site resolver is now also required, due the fact that it is needed for the preview mode and on demand revalidation.

Screenshot of the UI change:
Screenshot 2024-01-18 at 11 28 15

Copy link

vercel bot commented Jan 18, 2024

@bojanbogdanovic is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

@jeffschuler
Copy link

This is working for us, and very much needed. Thanks @bojanbogdanovic!

Here are the changes as a patch for the Next module in Drupal:
next_drupal-660-5c0d143.patch

@JohnAlbin
Copy link
Contributor

Merge conflicts with a previous PR need to be resolved. Sorry about that!

@bojanbogdanovic
Copy link
Contributor Author

Bump! Merge conflict is resolved.

@minnur minnur self-requested a review April 21, 2025 01:21
minnur
minnur previously approved these changes Apr 21, 2025
Copy link
Contributor

@minnur minnur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@timdiels1
Copy link

When using the PR, I get errors when switching the plugin:

Warning: Undefined array key "site_resolver_settings_container" in Drupal\next\Form\NextEntityTypeConfigForm->ajaxReplaceSiteResolverSettingsForm() (line 250 of /var/www/html/drupal/web/modules/contrib/next/src/Form/NextEntityTypeConfigForm.php)

Something went wrong with the rebase?

Because the code is not showing the text for preview but for draft mode?

@timdiels1
Copy link

I'm not sure that I can do the changes directly in the PR. So this is the patch file that can be used for 2.x if you install the module from Drupal.org
next_drupal-660-c8f3000.patch

@bojanbogdanovic
Copy link
Contributor Author

@timdiels1 I just pushed a fix, please take a look.

@timdiels1
Copy link

That will fix it yes, but then again I'm seeing still references to 'draft' in code while the screenshot you provided talks about the preview.

@bojanbogdanovic
Copy link
Contributor Author

Yea the PR is pretty old and same goes for the screenshot, preview mode got changed to draft mode, see: 11e108a

I updated the key/label to make it consistent.

@timdiels1
Copy link

I see, thank you so much for the changes and explanation. Anyone following, please ignore my patch then and use the code changes that are now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants