Fix name resolution in package __init__.py #18159
Open
+95
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When resolving the name while linting a package's
__init__.pyfile, ruff was considering__init__to be a proper module name. Whereas it's not really. Classes, functions, and other objects defined in__init__.pywill belong to the package. This PR fixes that resolution. In particular,D103, andPLW0406were affected. Maybe more that I couldn't find.Test Plan
I've added tests for the two rules I could find were affected by not properly resolving qualified names of objects inside a package's
__init__.py.