-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
This set of commits replaces macros with more modern constructs if they are available. #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Memory usage change @ 3065585
Click for full report table
Click for full report CSV
|
Part of these changes are already made in https://github.com/arduino/ArduinoCore-API, though not all of them. I believe that if these changes are made, they should be made in that repo (and this repo should start using that one, hopefully soon...). One consideration is that existing code might be using |
Memory usage change @ a168f39
Click for full report table
Click for full report CSV
|
Memory usage change @ a0cfbf1
Click for full report table
Click for full report CSV
|
Incorporates the changes from arduino/ArduinoCore-API@4986a66, arduino/ArduinoCore-API@445594a and . Co-Authored-By: Jesse Vincent <jesse@keyboard.io> Co-Authored-By: Martino Facchin <m.facchin@arduino.cc>
…` in the case of C++. Co-Authored-By: Matthijs Kooijman <matthijs@stdin.nl>
b7f377d
to
a23bf39
Compare
Memory usage change @ a23bf39
Click for full report table
Click for full report CSV
|
Memory usage change @ b7f377d
Click for full report table
Click for full report CSV
|
Macros are big issues because they are not "AST-safe" and wreck the things. This set of commits replaces them with more modern and more safe mostly (for sane use-cases) backward-compatible analogues in order to reduce the probability of unintended effects happening.
It is likely this set of commits should be applied to other cores too.
CLA won't be signed (because it is cancer destroying free software), everyone can consider any original contributions within this commits as licensed under Unlicense license.