Skip to content

Use NetworkConfigurator #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2025
Merged

Use NetworkConfigurator #535

merged 6 commits into from
May 21, 2025
+1,303 −42

Conversation

fabik111
Copy link
Contributor

Edit the ArduinoIoTCloudTCP FSM for using the NetworkConfigurator

  • added new method for: setting the NetworkConfigurator void setConfigurator(NetworkConfiguratorClass & configurator)
  • added a new state for getting the network configuration from the NVS and initialize the networkconfigutor
  • added a new state for handling the update of network credentials
  • added a new method for disconnecting from the AIoTCloud void disconnect()

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (cc01f43) to head (2b11b7e).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          32       32           
  Lines        1376     1376           
=======================================
  Hits         1306     1306           
  Misses         70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fabik111 fabik111 force-pushed the use-networkconfigurator branch from bd3fd1f to 068496c Compare March 28, 2025 10:23
per1234
per1234 requested changes Mar 28, 2025
View reviewed changes
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 28, 2025
@fabik111 fabik111 force-pushed the use-networkconfigurator branch 8 times, most recently from 380e974 to 8047509 Compare April 8, 2025 13:02
@fabik111 fabik111 force-pushed the use-networkconfigurator branch 2 times, most recently from a2067ea to 819161c Compare April 14, 2025 11:57
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@fabik111 fabik111 force-pushed the use-networkconfigurator branch from e749fc3 to bbf3f69 Compare April 14, 2025 14:34
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
pennam
pennam reviewed May 14, 2025
View reviewed changes
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@fabik111 fabik111 force-pushed the use-networkconfigurator branch 3 times, most recently from 001c63f to ef8fc29 Compare May 15, 2025 14:09
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@fabik111
use network configurator in iotCloud
37df5db 
update example of sketch that uses the NetworkConfigurator

use NetworkConfigurator wrappers for agentsManager

update ci test for networkConfigurator

add Arduino_NetworkConfigurator dep to library.properties
fabik111 added 2 commits May 15, 2025 16:41
@fabik111
add disconnect method
00cc42d
@fabik111
new Provisioning_2.0 sketch
3c158b9 
add GET_PROVISIONING_SKETCH_VERSION command

add define for compile with test env
@fabik111 fabik111 force-pushed the use-networkconfigurator branch from ef8fc29 to db2abdf Compare May 15, 2025 14:42
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
fabik111 and others added 3 commits May 20, 2025 14:11
@fabik111
Update NetworkConfigurator includes
5f09d2b 
examples: NetConfig, use h-char-sequence

examples: NetConfig, explicitly include NetworkConfigurator
@pennam @fabik111
style fixes
5404b82
@pennam @fabik111
TCP: add NetworkConfigurator version to printDebugInfo
2b11b7e
@fabik111 fabik111 force-pushed the use-networkconfigurator branch from db2abdf to 2b11b7e Compare May 20, 2025 12:13
@github-actions GitHub Actions
Copy link

Memory usage change @ 2b11b7e

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +8 - +168 0.0 - +0.01 🔺 0 - +8 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +8 - +136 0.0 - +0.01 🔺 0 - +8 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +6328 0.0 - +0.32 🔺 0 - +200 0.0 - +0.04
arduino:mbed_nano:nanorp2040connect 🔺 0 - +152 0.0 - 0.0 🔺 0 - +8 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +6320 0.0 - +0.32 🔺 0 - +200 0.0 - +0.04
arduino:mbed_opta:opta 🔺 0 - +7072 0.0 - +0.36 🔺 0 - +208 0.0 - +0.04
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +7472 0.0 - +0.36 🔺 0 - +368 0.0 - +0.07
arduino:renesas_uno:unor4wifi 🔺 +624 - +10840 +0.24 - +4.14 🔺 +328 - +932 +1.0 - +2.84
arduino:samd:mkr1000 🔺 0 - +136 0.0 - +0.05 🔺 0 - +8 0.0 - +0.02
arduino:samd:mkrgsm1400 🔺 0 - +128 0.0 - +0.05 🔺 0 - +8 0.0 - +0.02
arduino:samd:mkrnb1500 🔺 0 - +128 0.0 - +0.05 🔺 0 - +8 0.0 - +0.02
arduino:samd:mkrwan1300 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +128 0.0 - +0.05 🔺 0 - +8 0.0 - +0.02
arduino:samd:nano_33_iot 🔺 0 - +128 0.0 - +0.05 🔺 0 - +8 0.0 - +0.02
esp32:esp32:esp32 🔺 +20 - +220 0.0 - +0.02 🔺 0 - +8 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +160 - +176 +0.02 - +0.02 🔺 0 - +8 0.0 - +0.01
rp2040:rp2040:rpipicow 🔺 +128 - +136 +0.01 - +0.01 🔺 0 - +8 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/ArduinoIoTCloud-Callbacks
flash		 % examples/ArduinoIoTCloud-Callbacks
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/ArduinoIoTCloud-DeferredOTA
flash		 % examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables		 % examples/ArduinoIoTCloud-Notecard
flash		 % examples/ArduinoIoTCloud-Notecard
RAM for global variables		 % examples/ArduinoIoTCloud-Schedule
flash		 % examples/ArduinoIoTCloud-Schedule
RAM for global variables		 % examples/ArduinoIoTCloud-NetConfig
flash		 % examples/ArduinoIoTCloud-NetConfig
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:esp32:nano_nora 148 0.0 0 0.0 144 0.0 8 0.0 152 0.0 0 0.0 168 0.01 8 0.0 148 0.0 8 0.0 8 0.0 0 0.0 140 0.0 0 0.0
arduino:mbed_edge:edge_control 136 0.01 0 0.0 136 0.01 8 0.0 136 0.01 0 0.0 136 0.01 8 0.0 8 0.0 0 0.0 136 0.01 8 0.0
arduino:mbed_giga:giga 6328 0.32 200 0.04 6328 0.32 168 0.03 6320 0.32 200 0.04 6264 0.32 200 0.04 6320 0.32 200 0.04 272 0.01 32 0.01 6328 0.32 200 0.04 N/A N/A N/A N/A 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 152 0.0 8 0.0 152 0.0 8 0.0 152 0.0 8 0.0 148 0.0 8 0.0 152 0.0 8 0.0 10 0.0 0 0.0 152 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 6256 0.32 200 0.04 6320 0.32 168 0.03 6320 0.32 200 0.04 6320 0.32 168 0.03 6320 0.32 200 0.04 208 0.01 32 0.01 6320 0.32 168 0.03 N/A N/A N/A N/A 0 0.0 0 0.0
arduino:mbed_opta:opta 6872 0.35 176 0.03 7072 0.36 208 0.04 6800 0.35 176 0.03 6808 0.35 208 0.04 6864 0.35 176 0.03 272 0.01 32 0.01 6808 0.35 208 0.04 N/A N/A N/A N/A 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 7448 0.36 368 0.07 7472 0.36 336 0.06 7448 0.36 368 0.07 7440 0.35 336 0.06 320 0.02 48 0.01 7448 0.36 336 0.06 N/A N/A N/A N/A 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 10816 4.13 336 1.03 10840 4.14 328 1.0 10816 4.13 336 1.03 10808 4.12 328 1.0 624 0.24 932 2.84 10824 4.13 328 1.0 N/A N/A N/A N/A
arduino:samd:mkr1000 128 0.05 8 0.02 136 0.05 8 0.02 128 0.05 8 0.02 128 0.05 8 0.02 8 0.0 0 0.0 128 0.05 8 0.02 0 0.0 0 0.0
arduino:samd:mkrgsm1400 128 0.05 8 0.02 128 0.05 8 0.02 128 0.05 8 0.02 120 0.05 8 0.02 8 0.0 0 0.0 128 0.05 8 0.02 0 0.0 0 0.0
arduino:samd:mkrnb1500 128 0.05 8 0.02 128 0.05 8 0.02 128 0.05 8 0.02 128 0.05 8 0.02 8 0.0 0 0.0 128 0.05 8 0.02 0 0.0 0 0.0
arduino:samd:mkrwan1300 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrwifi1010 128 0.05 8 0.02 128 0.05 0 0.0 128 0.05 8 0.02 128 0.05 0 0.0 128 0.05 0 0.0 8 0.0 0 0.0 128 0.05 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 128 0.05 8 0.02 128 0.05 0 0.0 128 0.05 8 0.02 128 0.05 0 0.0 128 0.05 0 0.0 16 0.01 0 0.0 128 0.05 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 196 0.01 0 0.0 200 0.02 8 0.0 220 0.02 0 0.0 208 0.02 8 0.0 192 0.01 8 0.0 20 0.0 0 0.0 220 0.02 0 0.0
esp8266:esp8266:huzzah 176 0.02 8 0.01 160 0.02 0 0.0 160 0.02 8 0.01 160 0.02 0 0.0 160 0.02 0 0.0
rp2040:rp2040:rpipicow 136 0.01 0 0.0 136 0.01 8 0.0 128 0.01 8 0.0 128 0.01 8 0.0
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/ArduinoIoTCloud-Notecard<br>flash,%,examples/ArduinoIoTCloud-Notecard<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/ArduinoIoTCloud-NetConfig<br>flash,%,examples/ArduinoIoTCloud-NetConfig<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,148,0.0,0,0.0,144,0.0,8,0.0,152,0.0,0,0.0,168,0.01,8,0.0,148,0.0,8,0.0,8,0.0,0,0.0,140,0.0,0,0.0
arduino:mbed_edge:edge_control,136,0.01,0,0.0,136,0.01,8,0.0,136,0.01,0,0.0,136,0.01,8,0.0,,,,,8,0.0,0,0.0,136,0.01,8,0.0
arduino:mbed_giga:giga,6328,0.32,200,0.04,6328,0.32,168,0.03,6320,0.32,200,0.04,6264,0.32,200,0.04,6320,0.32,200,0.04,272,0.01,32,0.01,6328,0.32,200,0.04,N/A,N/A,N/A,N/A,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,152,0.0,8,0.0,152,0.0,8,0.0,152,0.0,8,0.0,148,0.0,8,0.0,152,0.0,8,0.0,10,0.0,0,0.0,152,0.0,8,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,6256,0.32,200,0.04,6320,0.32,168,0.03,6320,0.32,200,0.04,6320,0.32,168,0.03,6320,0.32,200,0.04,208,0.01,32,0.01,6320,0.32,168,0.03,N/A,N/A,N/A,N/A,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,6872,0.35,176,0.03,7072,0.36,208,0.04,6800,0.35,176,0.03,6808,0.35,208,0.04,6864,0.35,176,0.03,272,0.01,32,0.01,6808,0.35,208,0.04,N/A,N/A,N/A,N/A,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,7448,0.36,368,0.07,7472,0.36,336,0.06,7448,0.36,368,0.07,7440,0.35,336,0.06,,,,,320,0.02,48,0.01,7448,0.36,336,0.06,N/A,N/A,N/A,N/A,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,10816,4.13,336,1.03,10840,4.14,328,1.0,10816,4.13,336,1.03,10808,4.12,328,1.0,,,,,624,0.24,932,2.84,10824,4.13,328,1.0,N/A,N/A,N/A,N/A,,,,,,,,
arduino:samd:mkr1000,128,0.05,8,0.02,136,0.05,8,0.02,128,0.05,8,0.02,128,0.05,8,0.02,,,,,8,0.0,0,0.0,128,0.05,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,128,0.05,8,0.02,128,0.05,8,0.02,128,0.05,8,0.02,120,0.05,8,0.02,,,,,8,0.0,0,0.0,128,0.05,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,128,0.05,8,0.02,128,0.05,8,0.02,128,0.05,8,0.02,128,0.05,8,0.02,,,,,8,0.0,0,0.0,128,0.05,8,0.02,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,,,,,8,0.0,0,0.0,,,,,,,,,,,,,,,,
arduino:samd:mkrwifi1010,128,0.05,8,0.02,128,0.05,0,0.0,128,0.05,8,0.02,128,0.05,0,0.0,128,0.05,0,0.0,8,0.0,0,0.0,128,0.05,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,128,0.05,8,0.02,128,0.05,0,0.0,128,0.05,8,0.02,128,0.05,0,0.0,128,0.05,0,0.0,16,0.01,0,0.0,128,0.05,0,0.0,,,,,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,196,0.01,0,0.0,200,0.02,8,0.0,220,0.02,0,0.0,208,0.02,8,0.0,192,0.01,8,0.0,20,0.0,0,0.0,220,0.02,0,0.0,,,,,,,,,,,,
esp8266:esp8266:huzzah,176,0.02,8,0.01,160,0.02,0,0.0,160,0.02,8,0.01,160,0.02,0,0.0,,,,,,,,,160,0.02,0,0.0,,,,,,,,,,,,
rp2040:rp2040:rpipicow,136,0.01,0,0.0,136,0.01,8,0.0,128,0.01,8,0.0,128,0.01,8,0.0,,,,,,,,,,,,,,,,,,,,,,,,

@pennam pennam merged commit 41ab915 into arduino-libraries:master May 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 requested changes

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabik111 @per1234 @pennam