Merge pull request #378 from pennam/onchange-cbk

pennam · web-flow · commit babad891cd99 · 2023-11-23T17:00:15.000+01:00
Avoid calling onchange callback on sync event if property isn't changed
diff --git a/src/property/Property.cpp b/src/property/Property.cpp
@@ -386,8 +386,10 @@ void onAutoSync(Property & property) {
 }
 
 void onForceCloudSync(Property & property) {
-  property.fromCloudToLocal();
-  property.execCallbackOnChange();
+  if (property.isDifferentFromCloud()) {
+    property.fromCloudToLocal();
+    property.execCallbackOnChange();
+  }
 }
 
 void onForceDeviceSync(Property & /* property */) {

Original file line number	Diff line number	Diff line change
`@@ -386,8 +386,10 @@ void onAutoSync(Property & property) {`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`void onForceCloudSync(Property & property) {`
`389`		`- property.fromCloudToLocal();`
`390`		`- property.execCallbackOnChange();`
	`389`	`+ if (property.isDifferentFromCloud()) {`
	`390`	`+ property.fromCloudToLocal();`
	`391`	`+ property.execCallbackOnChange();`
	`392`	`+ }`
`391`	`393`	`}`
`392`	`394`
`393`	`395`	`void onForceDeviceSync(Property & /* property */) {`